Review main Merged

51936[BUGFIX] EM: Highlighting for insecure/outdated extensions

Josef Glatz CR +2 V +2 Normal +50 −23 updated 03/07/17, 06:22

Commit message

- Fix styles for extensions marked insecure or outdated
  within the TYPO3 extension manager list.
- Fix and update styles for the extension upload form.

Make compiling css with grunt clean again when executing:
* install.css

This patch fixes also the version number of a bower dependency
which should reflect the installed version:
* matchHeight v0.7.0 to v0.7.2

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 1318

  1. Josef Glatz uploaded patch set 1 03/03/17, 14:02

  2. Josef Glatz updated the commit message in patch set 2 03/03/17, 14:03

  3. Josef Glatz commented on patch set 2 03/03/17, 14:05

    I will push an extra patch for the 7_6 branch. I think that would be the better solution, as they are different to much. What do you think?
  4. TYPO3com voted on patch set 1 V +1 03/03/17, 14:10 Completed build in 08m 20s on Fri, 3 Mar, 03:10 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8861

  5. TYPO3com voted on patch set 2 V +1 03/03/17, 14:12 Completed build in 09m 27s on Fri, 3 Mar, 03:12 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8862

  6. Josef Glatz updated the commit message in patch set 3 03/03/17, 14:24

  7. TYPO3com commented on patch set 3 03/03/17, 14:32 Completed build in 07m 40s on Fri, 3 Mar, 03:32 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8863

  8. Markus Klein updated the commit message in patch set 4 03/03/17, 15:12

  9. Markus Klein commented on patch set 4 03/03/17, 15:13

    _module_extensionmanager.less:232

    this is an id. there is no reason to add a tag selector
  10. TYPO3com voted on patch set 4 V +1 03/03/17, 15:19 Completed build in 06m 58s on Fri, 3 Mar, 04:19 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8866

  11. Josef Glatz uploaded patch set 5 03/03/17, 19:17

  12. Josef Glatz commented on patch set 5 03/03/17, 19:17

    Thx Markus! You're right!
  13. TYPO3com voted on patch set 5 V +1 03/03/17, 19:24 Completed build in 07m 31s on Fri, 3 Mar, 08:24 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8874

  14. Markus Klein voted on patch set 5 CR +1 V +1 03/04/17, 09:47

  15. Nicole Hummel commented on patch set 5 CR +1 V +1 03/06/17, 22:17

    As I'm not sure about the css part, I wait for another core member to merge ;-)
  16. Georg Ringer commented on patch set 5 CR +2 V +2 03/07/17, 06:19

    josef will do the backport, he promised ;)
  17. Gerrit merged patch set 5 03/07/17, 06:19

  18. Josef Glatz commented on patch set 6 03/07/17, 06:22

    Thx! I'll do the backport when I'm in the train :-)