Review main Merged

51948[TASK] Show actual connect problem in Install tool

Thomas Hohn CR +2 V +2 Easy +16 −5 updated 03/06/17, 13:47

Commit message

If a connection can't be established to the database show the
actual exception message instead of just asking the user to check.
Can be due to faulty configuration in LocalConfiguration.php

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1422

  1. Thomas Hohn uploaded patch set 1 03/04/17, 07:20

  2. TYPO3com voted on patch set 1 V -1 03/04/17, 07:26 Completed build in 05m 46s on Sat, 4 Mar, 08:26 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8884

  3. Thomas Hohn uploaded patch set 2 03/04/17, 07:32

  4. TYPO3com voted on patch set 2 V +1 03/04/17, 07:39 Completed build in 07m 05s on Sat, 4 Mar, 08:39 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8886

  5. Josef Glatz updated the commit message in patch set 3 03/04/17, 08:30

  6. TYPO3com voted on patch set 3 V +1 03/04/17, 08:39 Completed build in 08m 26s on Sat, 4 Mar, 09:39 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8890

  7. Thomas Hohn updated the commit message in patch set 4 03/04/17, 08:50

  8. TYPO3com voted on patch set 4 V +1 03/04/17, 08:59 Completed build in 08m 59s on Sat, 4 Mar, 09:59 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8891

  9. Markus Klein updated the commit message in patch set 5 03/04/17, 09:49

  10. Markus Klein commented on patch set 5 03/04/17, 09:52

    DatabaseConnect.php:132

    success

    DatabaseConnect.php:137

    why that?

    DatabaseConnect.php:215

    return $this->isConnectSuccessfulWithExceptionMessage()[0];

    DatabaseConnect.php:223

    : array
  11. TYPO3com voted on patch set 5 V +1 03/04/17, 09:59 Completed build in 09m 41s on Sat, 4 Mar, 10:59 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8892

  12. Thomas Hohn uploaded patch set 6 03/04/17, 12:31

  13. TYPO3com voted on patch set 6 V +1 03/04/17, 12:41 Completed build in 09m 10s on Sat, 4 Mar, 01:41 PM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8895

  14. Markus Klein voted on patch set 6 CR +1 03/04/17, 13:42

  15. Morton Jonuschat commented on patch set 6 03/04/17, 19:17

    DatabaseConnect.php:227

    I wonder if this is the best return value to use. We can achieve the same just by returning the error message/empty string on success have a less unwieldy handling of the return value. Converting to bool for use in isConnectSuccessfulWithExceptionMessage() is no problem as well.
  16. Thomas Hohn uploaded patch set 7 03/05/17, 10:52

  17. TYPO3com voted on patch set 7 V +1 03/05/17, 11:01 Completed build in 08m 54s on Sun, 5 Mar, 12:01 PM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8920

  18. Mathias Brodala commented on patch set 8 03/06/17, 08:25

    Published edit on patch set 7.
  19. TYPO3com voted on patch set 8 V +1 03/06/17, 08:35 Completed build in 09m 42s on Mon, 6 Mar, 09:35 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8939

  20. Markus Klein voted on patch set 8 CR +1 V +1 03/06/17, 09:49

  21. Stefan Neufeind commented on patch set 8 CR +2 V +2 03/06/17, 13:46

    works, shows for example: An exception occured in driver: Access denied for user 'asdasdasd'@'localhost' (using password: YES)
  22. Gerrit merged patch set 8 03/06/17, 13:47