51949[BUGFIX] Update ConsoleOutput functions to new Symfony console
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1012
-
Jigal van Hemert uploaded patch set 1 03/04/17, 07:59
-
TYPO3com voted on patch set 1 V +1 03/04/17, 08:06 Completed build in 06m 31s on Sat, 4 Mar, 09:06 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8888
-
Georg Ringer voted on patch set 1 CR +1 03/04/17, 19:43
-
Stefan Neufeind commented on patch set 1 CR -1 03/06/17, 11:27
We maybe want/need a documentation that the default-value changed? Maybe even backward-compatible (with deprecation etc.) in case somebody passes a bool? Change here needed so it matches the parameters of Symfony. In 7.6 DialogHelper was used. And there the $attempts were bool|int. So it's correct in 7.6 and changed between LTS-versions. -
Markus Sommer voted on patch set 1 CR +1 V +1 03/17/17, 11:33
-
Benni Mack commented on patch set 1 03/28/17, 17:18
we could instead do a casting of false to null inside the methods, throw a deprecation if it's "false"... -
Benni Mack uploaded patch set 2 03/29/17, 09:23
-
Benni Mack voted on patch set 2 CR +1 V +1 03/29/17, 09:24
-
Stefan Neufeind voted on patch set 2 CR +1 V +1 03/29/17, 09:30
-
TYPO3com voted on patch set 2 V +1 03/29/17, 09:39 Completed build in 15m 56s on Wed, 29 Mar, 11:39 AM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9870
-
Benni Mack voted on patch set 2 CR +2 V +2 03/29/17, 09:44
-
Gerrit merged patch set 2 03/29/17, 09:44