Review main Merged

51953[BUGFIX] Replace class property caching with runtime cache

Claus Due CR +2 V +2 Normal +103 −81 updated 09/30/18, 12:08

Commit message

PageRepository is now used independantly from TSFE
most of the time, and a new instance is created each time a
content element gets rendered. This means that the current
cache strategy using class properties gets flushed repeatedly
and multiple identical SQL requests to be sent to the DB.

By replacing the class property caching with runtime cache
which survives across instances, the problem is solved.

On some sites this represents a reduction of several hundred
SQL requests.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1930

Show 35 earlier messages
  1. Claus Due uploaded patch set 1 03/04/17, 16:00

  2. TYPO3com voted on patch set 1 V -1 03/04/17, 16:08 Completed build in 07m 50s on Sat, 4 Mar, 05:08 PM Test Summary: 16 of 56398 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8903

  3. Claus Due uploaded patch set 2 03/04/17, 16:44

  4. TYPO3com voted on patch set 2 V -1 03/04/17, 16:54 Completed build in 09m 12s on Sat, 4 Mar, 05:54 PM Test Summary: 16 of 56398 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8904

  5. Claus Due uploaded patch set 3 03/04/17, 16:54

  1. TYPO3com voted on patch set 3 V -1 03/04/17, 17:04 Completed build in 09m 43s on Sat, 4 Mar, 06:04 PM Test Summary: 16 of 56398 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8905

  2. Claus Due uploaded patch set 4 03/04/17, 17:19

  3. TYPO3com voted on patch set 4 V -1 03/04/17, 17:26 Completed build in 06m 51s on Sat, 4 Mar, 06:26 PM Test Summary: 16 of 56398 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8906

  4. Mathias Brodala commented on patch set 4 03/06/17, 08:28

    PageRepository.php:1981

    Shouldn't this be FrontendInterface instead?
  5. Mathias Schreiber uploaded patch set 5 02/12/18, 20:38

  6. TYPO3com voted on patch set 5 V -1 02/12/18, 20:38 Completed build in 10s on Mon, 12 Feb, 09:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19407

  7. Mathias Schreiber uploaded patch set 6 02/12/18, 20:39

  8. TYPO3com voted on patch set 6 V -1 02/12/18, 20:49 Completed build in 10m 13s on Mon, 12 Feb, 09:49 PM Test Summary: 16 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19408

  9. TYPO3com commented on patch set 6 02/12/18, 20:54 Completed build in 25m 02s on Mon, 12 Feb, 09:54 PM Test Summary: 16 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19408

  10. Georg Ringer commented on patch set 6 02/13/18, 04:15

    PageRepository.php:97

    v8 => v9, v9 => v10, also below
  11. Mathias Schreiber uploaded patch set 7 02/13/18, 08:23

  12. TYPO3com voted on patch set 7 V -1 02/13/18, 08:33 Completed build in 09m 54s on Tue, 13 Feb, 09:33 AM Test Summary: 17 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19440

  13. Mathias Schreiber commented on patch set 7 02/13/18, 08:37

    @Claus: This change breaks a lot of tests. I'll WIP this for the time being, since I don't have the time to explore this deeper right now.

    PageRepository.php:97 Reply

    Ack
  14. Mathias Schreiber updated the commit message in patch set 8 02/13/18, 08:37

  15. TYPO3com voted on patch set 8 V -1 02/13/18, 08:46 Completed build in 09m 02s on Tue, 13 Feb, 09:46 AM Test Summary: 16 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19443

  16. Benni Mack commented on patch set 8 09/29/18, 23:51

    FYI, I will work on that to finish it in the next days.
  17. Benni Mack wrote 09/29/18, 23:51

    Assignee added: Benni Mack <benni@typo3.org>
  18. Benni Mack uploaded patch set 9 09/30/18, 09:44

  19. TYPO3com voted on patch set 9 V -1 09/30/18, 09:52 Completed build in 08m 07s on Sun, 30 Sep, 11:52 AM Test Summary: 962 of 36919 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28985

  20. Benni Mack uploaded patch set 10 09/30/18, 11:29

  21. TYPO3com voted on patch set 10 V +1 09/30/18, 11:43 Completed build in 11m 19s on Sun, 30 Sep, 01:43 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29002

  22. Benni Mack voted on patch set 10 V +1 CR +1 09/30/18, 11:58

  23. Christian Kuhn voted on patch set 10 V +1 CR +1 09/30/18, 12:07

  24. Benni Mack voted on patch set 10 V +2 CR +2 09/30/18, 12:08

  25. Benni Mack merged patch set 11 09/30/18, 12:08