51957[TASK] Move $testExtensionsToLoad into setUp()
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 20
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php1+20 −8
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+19 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+20 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+19 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/EnableFieldsTest.php+16 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php+19 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+19 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+19 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+19 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+19 −5
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingStandaloneTest.php+24 −2
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingTest.php+24 −2
- typo3/sysext/impexp/Tests/Functional/Export/GroupFileAndFileReferenceItem/ExportTest.php+19 −6
- typo3/sysext/impexp/Tests/Functional/Export/GroupFileAndFileReferenceItemInFlexForm/ExportTest.php+19 −7
- typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecords/ExportTest.php+15 −3
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContent/ExportTest.php+15 −3
- typo3/sysext/impexp/Tests/Functional/Import/GroupFileAndFileReferenceItem/ImportInEmptyDatabaseTest.php+24 −7
- typo3/sysext/impexp/Tests/Functional/Import/GroupFileAndFileReferenceItemInFlexForm/ImportInEmptyDatabaseTest.php+24 −6
- typo3/sysext/rsaauth/Tests/Functional/Storage/SplitStorageTest.php+1 −9
- typo3/sysext/saltedpasswords/Tests/Functional/Task/BulkUpdateTaskTest.php+1 −9
Review log 1215
-
Anja Leichsenring uploaded patch set 1 03/05/17, 16:27
-
Anja Leichsenring uploaded patch set 2 03/05/17, 16:32
-
TYPO3com voted on patch set 1 V -1 03/05/17, 16:42 Completed build in 14m 29s on Sun, 5 Mar, 05:42 PM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8927
-
TYPO3com voted on patch set 2 V +1 03/05/17, 16:47 Completed build in 14m 18s on Sun, 5 Mar, 05:46 PM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8928
-
Anja Leichsenring uploaded patch set 3 03/05/17, 19:11
-
TYPO3com voted on patch set 3 V +1 03/05/17, 19:23 Completed build in 11m 26s on Sun, 5 Mar, 08:23 PM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8930
-
Anja Leichsenring commented on patch set 3 03/05/17, 20:33
see https://review.typo3.org/#/c/51958/ for a usage example. It actually works ;) -
Christian Kuhn commented on patch set 3 03/06/17, 08:00
Frankly, I'm not a very big fan of that: Extensions should usually not extend existing test cases. For the couple of Abstracts, they should be split in a way that either no further extension-load is needed, or they don't override that array and let this done by the single test cases. -
Anja Leichsenring commented on patch set 3 03/06/17, 09:04
that is not the intention. I want to run the core tests with defined test extensions loaded, so it is possible to see the actual changes that hooks or signals do to pure core behavior. To provide the extension and set it up for the test run is job of the ext author, not the core. But to make this working smooth, the core must slightly adapt to a consistent handling. -
Nicole Hummel commented on patch set 3 CR -1 03/06/17, 09:34
IMHO this patch has several flaws: - hides dependencies and makes it more complicated to see loaded extensions from a view in a functional test case - as far as I can see, this patch is breaking as it adds (and moves) extensions in testExtensionsToLoad and coreExtensionsToLoad. This might cause duplicate definition of extensions which result in uncatched exceptions during the setup -
Anja Leichsenring commented on patch set 3 03/06/17, 10:02
there is not a single file where the declaration of a test extension was added or removed. They only moved from header into setUp(). The behavior as well as the loading order has been preserved. The moving from test into core extensions to load was intended - the added extensions are core extensions. This is non breaking. -
Nicole Hummel commented on patch set 3 03/06/17, 10:19
AbstractDataHandlerActionTestCase.php:85If my own functional test case defines this test extension, after the merge the extension is in $this->testExtensionsToLoad two times (because there is no array_unique call, which ensures extensions are available only ones). This will result in an exception when test extensions are linked to the instance path, as a folder can be symlink only once. -
Anja Leichsenring commented on patch set 3 03/06/17, 10:26
Fair enough. This patch is about preserving behavior. You are not to extend existing core functional tests with your extension, or you need to take care yourself for the order. That's the case already before this change. The DataHandler tests itself extend each other, so the array_merge was necessary here. Olly obviously knew what he did when he introduced the structure, there is no duplication in the test extensions. For global registered test extension I made this: https://review.typo3.org/#/c/51958/ This patch brings the array_unique you request. Still, core tests must not be extended by extension tests. -
Susi Moog commented on patch set 3 CR -1 11/14/17, 07:40
I'm also not a fan of this change, abstraction hides things which I consider especially bad in a testing scenario. Your extension tests can already do what you want but in a more explicit way. In general you should prefer to use composition if you want to re-use parts of previous tests instead of inheritance, so maybe you can use these concepts instead. -
Benni Mack abandoned the change 11/28/17, 22:18
abandoned due to the comments from the core team.