Review main Merged

51959[BUGFIX] Always use forward slashes in Upgrade Analysis

Jigal van Hemert CR +2 V +2 Easy +2 −1 updated 03/07/17, 03:25

Commit message

In the Upgrade Analysis in the Install Tool only forward slashes
can be used in paths to prevent exceptions from being throws while
checking if the file is inside the documentation directory. If the path
is constructed with realpath() the path contains backslashes on Windows.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Nicole Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Jigal van Hemert uploaded patch set 1 03/05/17, 22:14

  2. TYPO3com voted on patch set 1 V +1 03/05/17, 22:23 Completed build in 08m 23s on Sun, 5 Mar, 11:22 PM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8934

  3. Nicole Hummel voted on patch set 1 CR +1 03/05/17, 23:29

  4. Stefan Neufeind voted on patch set 1 CR +1 03/06/17, 11:32

  5. Nicole Hummel voted on patch set 1 V +1 03/06/17, 22:20

  6. Georg Ringer voted on patch set 1 CR +2 V +2 03/07/17, 03:25

  7. Gerrit merged patch set 1 03/07/17, 03:25