Review main Merged

51984[BUGFIX] Do not overwrite inlineData in mergeResult

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 03/15/17, 10:37

Commit message

Instead of merging different inlineData results, the
FormResultCompiler has one seemingly leftover line of code
which overwrites the inlineData, leading to the situation
that only the last inlineData is kept.

In the list module when editing multiple fields with IRRE relations,
this leads to the fact that children can only be added
to the last element.

For some reason the same code does not expose the bug to the end user,
most likely due to different handling of the context data.

Nevertheless this obviously wrong line should also be removed in 7.6.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Volker Kemeter +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Helmut Hummel uploaded patch set 1 03/08/17, 20:55

  2. TYPO3com voted on patch set 1 V +1 03/08/17, 21:05 Completed build in 09m 26s on Wed, 8 Mar, 10:05 PM Test Summary: 56410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9010

  3. Markus Klein updated the commit message in patch set 2 03/08/17, 21:42

  4. Markus Klein commented on patch set 2 03/08/17, 21:43

    updated commit msg
    I would remove this line here, because it should be in the ticket and the releases line reflects that anyway
  5. TYPO3com voted on patch set 2 V +1 03/08/17, 21:52 Completed build in 10m 10s on Wed, 8 Mar, 10:52 PM Test Summary: 56410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9011

  6. Josef Glatz commented on patch set 2 03/09/17, 05:23

    I couldn't reproduce the bug anymore. ¯\_(ツ)_/¯ Is there any known area in the backend which could be also affected by this change?
  7. Josef Glatz commented on patch set 2 03/09/17, 05:34

    I've tested multiple-edit mode and single table mode -> bulk edit tt_content.image column only
  8. Helmut Hummel commented on patch set 2 03/09/17, 07:06

    I could reproduce this with bulk edit of pages media column
  9. Volker Kemeter commented on patch set 2 V +1 03/09/17, 08:21

    I couldn't reproduce that misbehaviour either. seems to work for me now. i tested it in the "multi-select" mode and the "field edit" mode.
  10. Josef Glatz voted on patch set 2 V +1 03/09/17, 08:52

  11. Benni Mack voted on patch set 2 CR +1 03/09/17, 12:47

  12. Wouter Wolters voted on patch set 2 CR +1 03/12/17, 10:05

  13. Christian Kuhn voted on patch set 2 CR +2 V +2 03/15/17, 10:09

  14. Gerrit merged patch set 2 03/15/17, 10:09

  15. Helmut Hummel commented on patch set 3 03/15/17, 10:37

    Thanks!