Review main Abandoned

51988[BUGFIX] correct handling of references in file list

Andreas Allacher CR 0 V 0 Easy +11 −3 updated 04/29/17, 18:26

Commit message

Deletion of files in file list has to take into account
if the references to that file have been deleted.

Due to the update to Doctrine DBAL the check
for this was wrong as it was using DeletedRestriction
which requires a TCA configuration for the table.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1418

  1. Andreas Allacher uploaded patch set 1 03/09/17, 11:41

  2. Andreas Allacher updated the commit message in patch set 2 03/09/17, 11:50

  3. TYPO3com voted on patch set 1 V +1 03/09/17, 11:53 Completed build in 11m 39s on Thu, 9 Mar, 12:53 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9026

  4. TYPO3com voted on patch set 2 V +1 03/09/17, 12:00 Completed build in 09m 45s on Thu, 9 Mar, 01:00 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9028

  5. Andreas Allacher uploaded patch set 3 03/09/17, 12:07

  6. Andreas Allacher commented on patch set 3 03/09/17, 12:07

    Found another instance in the utility with the wrong check
  7. TYPO3com voted on patch set 3 V +1 03/09/17, 12:15 Completed build in 07m 41s on Thu, 9 Mar, 01:15 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9029

  8. Mona Muzaffar voted on patch set 3 V +1 03/23/17, 12:34

  9. Mona Muzaffar voted on patch set 3 V 0 04/29/17, 17:08

  10. Mona Muzaffar commented on patch set 3 04/29/17, 17:09

    can't reproduce this issue in the current master anymore, so it might have been resolved in meantime
  11. Andreas Allacher updated the commit message in patch set 4 04/29/17, 17:10

  12. Andreas Allacher commented on patch set 4 04/29/17, 17:17

    I have checked and I think the original bug has been fixed with: https://git.typo3.org/Packages/TYPO3.CMS.git/commit/2aa304eb05e029f3a3fae1ff2b83416d6d522e3e But some other things in this change are probably not in it yet, like e.g. folderHasFilesInUse still doesn't check the delete condition but I think that would be a separte bugfix, so I think I probably should abandon this bugfix?
  13. TYPO3com voted on patch set 4 V +1 04/29/17, 17:18 Completed build in 08m 00s on Sat, 29 Apr, 07:18 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11099

  14. Andreas Allacher commented on patch set 4 04/29/17, 17:23

    The original bug was fixed with https://forge.typo3.org/issues/80692 However, if you then delete that file and try to delete the folder it will probably still not work as https://git.typo3.org/Packages/TYPO3.CMS.git/blob/master:/typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php#l516 does not add the necessary deleted check
  15. Andreas Allacher commented on patch set 4 04/29/17, 17:26

    EDIT to previous comment: not delete the file but to try to delete the folder that contains the file
  16. Mona Muzaffar commented on patch set 4 04/29/17, 17:36

    i also think it would be better if you abandon this ticket and create a new one. And write a new ticket description etc.
  17. Andreas Allacher abandoned the change 04/29/17, 18:17

    File deleetion has been fixed and for the folder there is a new ticket: https://forge.typo3.org/issues/81087
  18. Andreas Allacher commented on patch set 4 04/29/17, 18:26

    One more thing. When I created my original patch I checked all queries to ref_index and there was one point where I wasn't sure if it could be a problem or not, so I just modified it: https://review.typo3.org/#/c/51988/4/typo3/sysext/filelist/Classes/FileList.php Here the restrictions are not removed in makeRef. Not sure, it this will be an issue or not. Might be if someone sets restrictions to ref_index prior to the call to makeRef which is unlikely but probably not impossible.