51990[BUGFIX] Fix imagemagick commands when setting stripProfile to "0"
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1418
-
Paul Golmann uploaded patch set 1 03/09/17, 12:43
-
TYPO3com voted on patch set 1 V +1 03/09/17, 12:50 Completed build in 07m 15s on Thu, 9 Mar, 01:50 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9030
-
Paul Golmann wrote 03/09/17, 13:55
Topic set to issues/80208 -
Tymoteusz Motylewski commented on patch set 1 03/09/17, 14:21
CommandUtility.php:1141) has been 2) is it TypoScript or LocalConfiguration/Install tool setting? -
Paul Golmann commented on patch set 1 03/09/17, 14:30
> (1 comment) I can't really the defend the comment - i've just kept it as is, but as far as i can say it refers to the ###SkipStripProfile### which is only set by \TYPO3\CMS\Core\Resource\Processing\LocalCropScaleMaskHelper in the core. That helper get's used in various parts of the core mostly indirectly through it's "processingTaskTypes" identifier "Image.CropScaleMask" defined in sysext/core/Configuration/DefaultConfiguration.php. One usage is found in the ContentObjectRenderer which the comment seems to refer to. An example for that can be found in the issue in forge. -
Paul Golmann updated the commit message in patch set 2 05/29/17, 12:11
-
Xavier Perseguers commented on patch set 2 05/29/17, 12:17
Bug tracker says this bug occurs already in TYPO3 6.2, why are you not including: Releases: master, 8.7, 7.6 -
TYPO3com voted on patch set 2 V +1 05/29/17, 12:18 Completed build in 06m 59s on Mon, 29 May, 02:18 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11857
-
Paul Golmann commented on patch set 2 05/29/17, 12:27
> (1 comment) No real reason. Just my first RFC in a long time. Happy to add 7.6 and 8.7 :)Reply
No real reason. Just my first RFC in a long time. Happy to add 7.6 and 8.7 :) -
Paul Golmann updated the commit message in patch set 3 05/29/17, 12:28
-
TYPO3com voted on patch set 3 V +1 05/29/17, 12:35 Completed build in 06m 34s on Mon, 29 May, 02:35 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11859
-
Elmar Hinz commented on patch set 3 05/29/17, 14:16
CommandUtility.php:114The comment is sparse. It's difficult for me to quickly understand what's going on.I think the comment should explain the concept more verbose. I give an example even if i don't finally understand the code: If all configuration prerequisites are given to strip the profile information, then set up the strip command parameters string. Take care that a potential ###SkipStripProfile### entry is removed. -
Mathias Schreiber updated the commit message in patch set 4 03/01/18, 21:11
-
TYPO3com voted on patch set 4 V +1 03/01/18, 21:23 Completed build in 11m 44s on Thu, 1 Mar, 10:23 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20398
-
Mathias Schreiber voted on patch set 4 V +1 CR +1 03/01/18, 21:41
-
Christian Kuhn commented on patch set 4 03/01/18, 22:19
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 75dea495667f82e0e5450d8a4783341e1b10ccc9 -
Christian Kuhn voted on patch set 4 V +2 CR +2 03/01/18, 22:19
-
Christian Kuhn merged patch set 5 03/01/18, 22:19