Review main Merged

51991[BUGFIX] Wrong variable checked in BrowseLinksController

Christer V CR +2 V +2 Easy +1 −1 updated 03/28/17, 11:57

Commit message

Changed so the correct variable classesAnchorDefaultTitle is checked.

In BrowseLinksController::getTitleField the wrong variable was checked,
which could cause faulty behaviour and an PHP warning since $title could
become null instead of the empty string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Christer V uploaded patch set 1 03/09/17, 13:00

  2. TYPO3com voted on patch set 1 V +1 03/09/17, 13:08 Completed build in 07m 06s on Thu, 9 Mar, 02:08 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9031

  3. Thomas Hohn voted on patch set 1 CR +1 03/09/17, 13:57

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 03/10/17, 21:38

  5. Gerrit merged patch set 1 03/10/17, 21:38

  6. Markus Klein commented on patch set 2 03/15/17, 00:38

    Post -1. 1) the code shall be improved 2) the same bug seems to be present in htmlarea too 3) of course this needs to be fixed in 7.6 as well

    BrowseLinksController.php:447

    this can be improved to use "?: ''"
  7. Markus Klein commented on patch set 2 03/22/17, 20:20

    @all: Did anybody take care about my remarks already??
  8. Frans Saris commented on patch set 2 03/24/17, 07:32

    I didn't have the time to look into this
  9. Christer V commented on patch set 2 03/28/17, 06:52

    I will do it
  10. Markus Klein commented on patch set 2 03/28/17, 11:57

    Thx Christer