Review main Merged

51995[TASK] Make InvalidXmlFileException for language files more verbose

Andreas Kienast CR +2 V +2 Easy +10 −2 updated 03/10/17, 21:31

Commit message

The message of the InvalidXmlFileException, thrown when parsing broken
language files now always shows the last occured error in libxml with
the affected file and line.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 03/10/17, 11:22

  2. TYPO3com voted on patch set 1 V +1 03/10/17, 11:30 Completed build in 08m 25s on Fri, 10 Mar, 12:30 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9039

  3. Markus Klein voted on patch set 1 CR +1 V +1 03/10/17, 15:00

  4. Josef Glatz voted on patch set 1 CR +1 03/10/17, 21:13

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 03/10/17, 21:30

  6. Gerrit merged patch set 1 03/10/17, 21:30

  7. Christian Kuhn commented on patch set 2 03/10/17, 21:31

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 51778aa661ccd4c3eeb87c213560b846ffb3ae94