51997[BUGFIX] EXT:form - change type of getRendererClassName() to string
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Ralf Zimmermann +1
-
Verified V +2
- Christian Kuhn +2
- Ralf Zimmermann +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1317
-
Martin Kutschker uploaded patch set 1 03/10/17, 18:38
-
TYPO3com voted on patch set 1 V +1 03/10/17, 18:45 Completed build in 07m 17s on Fri, 10 Mar, 07:45 PM Test Summary: 56446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9043
-
Ralf Zimmermann updated the commit message in patch set 2 03/11/17, 10:51
-
Ralf Zimmermann voted on patch set 2 CR +1 V +1 03/11/17, 10:51
-
TYPO3com voted on patch set 2 V +1 03/11/17, 10:58 Completed build in 07m 34s on Sat, 11 Mar, 11:58 AM Test Summary: 56452 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9057
-
Susi Moog commented on patch set 3 03/12/17, 09:29
Published edit on patch set 2. -
Susi Moog voted on patch set 3 CR +1 03/12/17, 09:29
-
TYPO3com voted on patch set 3 V +1 03/12/17, 09:42 Completed build in 13m 02s on Sun, 12 Mar, 10:42 AM Test Summary: 56458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9068
-
Björn Jacob commented on patch set 3 03/14/17, 07:51
I don't get the commit message. "Make sure is string...". What's missing? -
Susi Moog commented on patch set 3 03/14/17, 07:54
@Bjoern Currently it may return null or string - after the patch it's ensured that it will always return a string. -
Björn Jacob commented on patch set 3 03/14/17, 07:55
Yes, I do get the meaning of the patch, but IMHO the commit message is missing a word or something. I cannot figure what is missing but the sentence is odd. -
Susi Moog updated the commit message in patch set 4 03/14/17, 09:07
-
Susi Moog commented on patch set 4 03/14/17, 09:07
Ah, now I get it. I hopefully fixed it. -
TYPO3com voted on patch set 4 V +1 03/14/17, 09:14 Completed build in 07m 14s on Tue, 14 Mar, 10:14 AM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9140
-
Ralf Zimmermann voted on patch set 4 CR +1 V +1 03/19/17, 18:15
-
Christian Kuhn voted on patch set 4 CR +2 V +2 03/20/17, 18:34
-
Gerrit merged patch set 4 03/20/17, 18:34