Review main Merged

52009[BUGFIX] Use-fine grained request types in Applications

Benni Mack CR +2 V +2 Easy +2 −2 updated 03/12/17, 10:01

Commit message

The new CLI console application as well as the install tool define
the request type as simulating backend, which is wrong, as they are
a separate application indeed.

In order to use more fine-grained different validations in the future
the request types are set as they are.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 03/12/17, 07:21

  2. Benni Mack commented on patch set 1 03/12/17, 07:25

    Currently, this change is mostly harmless, as TYPO3_REQUESTTYPE_BE is not seriously in use.
  3. TYPO3com voted on patch set 1 V -1 03/12/17, 07:29 Completed build in 08m 22s on Sun, 12 Mar, 08:29 AM Test Summary: 1 of 56458 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9067

  4. TYPO3com voted on patch set 1 V +1 03/12/17, 09:14 Completed build in 2h 01m 51s on Sun, 12 Mar, 10:14 AM Test Summary: 56458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9067

  5. Susi Moog voted on patch set 1 CR +1 V +1 03/12/17, 09:21

  6. Wouter Wolters voted on patch set 1 CR +2 V +2 03/12/17, 10:01

  7. Gerrit merged patch set 1 03/12/17, 10:01