Review main Merged

52011[TASK] Resolve cross dep between EXT:backend and EXT:feedit

Claus Due CR +2 V +2 Normal +74 −22 updated 03/16/17, 05:03

Commit message

This patch moves frontend-editing intialisation from the
EditDocumentController (EXT:backend) to a signal listener
in EXT:feedit. Step towards extracting EXT:feedit to TER.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Tymoteusz Motylewski +1
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 912

  1. Claus Due uploaded patch set 1 03/12/17, 13:26

  2. Claus Due updated the commit message in patch set 2 03/12/17, 13:27

  3. TYPO3com voted on patch set 1 V -1 03/12/17, 13:36 Completed build in 09m 28s on Sun, 12 Mar, 02:36 PM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9077

  4. TYPO3com voted on patch set 2 V -1 03/12/17, 13:39 Completed build in 11m 56s on Sun, 12 Mar, 02:39 PM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9078

  5. Wouter Wolters commented on patch set 2 03/12/17, 14:06

    FrontendEditAssetLoader.php:23

    no @package
  6. Wouter Wolters commented on patch set 2 03/12/17, 14:06

    # missing
  7. Claus Due uploaded patch set 3 03/12/17, 14:14

  8. TYPO3com voted on patch set 3 V +1 03/12/17, 14:22 Completed build in 07m 04s on Sun, 12 Mar, 03:22 PM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9079

  9. Tymoteusz Motylewski voted on patch set 3 CR +1 03/15/17, 20:06

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 03/15/17, 20:43

  11. Georg Ringer voted on patch set 3 CR +2 V +2 03/16/17, 05:03

  12. Gerrit merged patch set 3 03/16/17, 05:03