Review main Abandoned

52031[BUGFIX] Renew expiration date of lifetime-based session cookies

Andreas Kienast CR 0 V 0 Easy +1 −1 updated 03/14/17, 07:46

Commit message

If TYPO3 is configured to set an expiration date at session cookies,
the expiration date doesn’t get refreshed, resulting in getting logged
off after a configurable time frame, no matter whether the user was
actually active or not.

The check in AbstractUserAuthentication for setting the session cookie is
now extended to also check whether the cookie is configured to be set with
a expiration date.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 23

  1. Andreas Kienast uploaded patch set 1 03/13/17, 14:15

  2. TYPO3com voted on patch set 1 V +1 03/13/17, 14:22 Completed build in 06m 32s on Mon, 13 Mar, 03:22 PM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9123

  3. Andreas Kienast abandoned the change 03/14/17, 07:46

    The real issue is caused by some badly implemented custom core patches fiddling with session internals.