Review main Merged

52032[FEATURE] Add signal slot for user switch

Silvia Bigler CR +2 V +2 Easy +38 −0 updated 02/12/18, 19:23

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1422

  1. Silvia Bigler uploaded patch set 1 03/13/17, 15:21

  2. TYPO3com voted on patch set 1 V +1 03/13/17, 15:29 Completed build in 07m 34s on Mon, 13 Mar, 04:29 PM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9125

  3. Jan Helke voted on patch set 1 CR +1 05/17/17, 16:35

  4. Wouter Wolters commented on patch set 1 CR -1 05/18/17, 07:01

    A FEATURE needs a RST file that describes the new feature. Also the commit message should contain a bit more information what this new signal is about. The RST file can be created on https://forger.typo3.org/utility/rst
  5. Frank Nägler commented on patch set 1 CR -1 05/19/17, 21:01

    As mentioned by Wouter, this patch need a rst file, also please take care of my comment and add an emit-method.

    BackendUserController.php:268

    Please create an emit-method and call it here, instead of direct usage of the signalSlotDispatcher.
  6. Frank Nägler uploaded patch set 2 02/12/18, 17:44

  7. TYPO3com voted on patch set 2 V -1 02/12/18, 17:52 Completed build in 08m 25s on Mon, 12 Feb, 06:52 PM Test Summary: 2 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19386

  8. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/12/18, 17:53

  9. TYPO3com commented on patch set 2 02/12/18, 17:57 Completed build in 21m 52s on Mon, 12 Feb, 06:57 PM Test Summary: 2 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19386

  10. TYPO3com voted on patch set 2 V +1 02/12/18, 18:20 Completed build in 58m 28s on Mon, 12 Feb, 07:20 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19386

  11. Frank Nägler voted on patch set 2 V +2 CR +2 02/12/18, 18:42

  12. Mathias Schreiber commented on patch set 3 02/12/18, 18:45

    Published edit on patch set 2.
  13. TYPO3com voted on patch set 3 V -1 02/12/18, 18:45 Completed build in 08s on Mon, 12 Feb, 07:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19392

  14. Mathias Schreiber commented on patch set 4 02/12/18, 18:45

    Published edit on patch set 3.
  15. Christian Kuhn commented on patch set 5 02/12/18, 18:47

    Published edit on patch set 4.
  16. Christian Kuhn voted on patch set 5 V +1 CR +1 02/12/18, 18:48

  17. TYPO3com voted on patch set 4 V -1 02/12/18, 18:53 Completed build in 08m 11s on Mon, 12 Feb, 07:53 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19393

  18. TYPO3com voted on patch set 5 V +1 02/12/18, 18:55 Completed build in 08m 33s on Mon, 12 Feb, 07:55 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19394

  19. TYPO3com voted on patch set 4 V +1 02/12/18, 18:58 Completed build in 20m 54s on Mon, 12 Feb, 07:58 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19393

  20. Mathias Schreiber voted on patch set 5 V +1 CR +1 02/12/18, 19:23

  21. Christian Kuhn voted on patch set 5 V +2 CR +2 02/12/18, 19:23

  22. Christian Kuhn merged patch set 6 02/12/18, 19:23