Review main Merged

52049[TASK] Use direct array assignments instead of array_push

Cedric Ziel CR +2 V +2 Normal +25 −28 updated 03/28/17, 17:27

Commit message

Direct assignments are usually 2x faster and often more readable
when pushing one value only.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Files 16

Review log 69

  1. Cedric Ziel uploaded patch set 1 03/15/17, 09:58

  2. Cedric Ziel updated the commit message in patch set 2 03/15/17, 10:03

  3. TYPO3com voted on patch set 1 V +1 03/15/17, 10:12 Completed build in 14m 04s on Wed, 15 Mar, 11:12 AM Test Summary: 56479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9186

  4. TYPO3com voted on patch set 2 V -1 03/15/17, 10:14 Completed build in 10m 30s on Wed, 15 Mar, 11:14 AM Test Summary: 1 of 56488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9187

  5. Cedric Ziel rebased onto patch set 3 03/15/17, 11:19

  6. TYPO3com voted on patch set 3 V +1 03/15/17, 11:29 Completed build in 09m 41s on Wed, 15 Mar, 12:29 PM Test Summary: 56479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9194

  7. Benni Mack voted on patch set 3 CR +1 V +1 03/28/17, 17:23

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 03/28/17, 17:27

  9. Gerrit merged patch set 3 03/28/17, 17:27