Review TYPO3_7-6 Merged

52050[BUGFIX] Do not overwrite inlineData in mergeResult

Christian Kuhn CR +2 V +2 Easy +0 −1 updated 03/15/17, 10:43

Commit message

Instead of merging different inlineData results, the
FormResultCompiler has one seemingly leftover line of code
which overwrites the inlineData, leading to the situation
that only the last inlineData is kept.

In the list module when editing multiple fields with IRRE relations,
this leads to the fact that children can only be added
to the last element.

For some reason the same code does not expose the bug to the end user,
most likely due to different handling of the context data.

Nevertheless this obviously wrong line should also be removed in 7.6.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 03/15/17, 10:10

  2. TYPO3com voted on patch set 1 V +1 03/15/17, 10:15 Completed build in 04m 28s on Wed, 15 Mar, 11:15 AM Test Summary: 38591 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-815

  3. Christian Kuhn commented on patch set 1 CR +2 V +2 03/15/17, 10:19

    that should be safe in 7.6, too.
  4. Gerrit merged patch set 1 03/15/17, 10:19

  5. Helmut Hummel commented on patch set 2 03/15/17, 10:43

    also thanks for the backport!