Review main Merged

52075[TASK] Deprecate BackendUtility::getRecordRaw

Manuel Selbach CR +2 V +2 Normal +184 −24 updated 03/22/17, 15:43

Commit message

Since we follow the principle of "prepared statement", the method
getRecordRaw will break this behaviour. Within the "where" parameter
of the function it is possible to pass a malformed query part.

Thus we should remove it, as the queryBuilder should be used everywhere
in the future to increase visiblity of which query will be processed at
a concrete point of code and to force the concept of prepared statements.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 2028

Show 23 earlier messages
  1. Manuel Selbach uploaded patch set 1 03/17/17, 10:34

  2. TYPO3com voted on patch set 1 V -1 03/17/17, 10:41 Completed build in 06m 52s on Fri, 17 Mar, 11:41 AM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9252

  3. Manuel Selbach uploaded patch set 2 03/17/17, 12:00

  1. TYPO3com voted on patch set 2 V +1 03/17/17, 12:09 Completed build in 09m 03s on Fri, 17 Mar, 01:09 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9259

  2. Wouter Wolters commented on patch set 2 03/18/17, 15:17

    ReferenceIndex.php:230

    no need to reset the restrictions here?
  3. Manuel Selbach commented on patch set 2 03/18/17, 19:59

    ReferenceIndex.php:230 Reply

    You're absolutely right, good catch
  4. Manuel Selbach uploaded patch set 3 03/18/17, 20:00

  5. TYPO3com voted on patch set 3 V +1 03/18/17, 20:09 Completed build in 08m 56s on Sat, 18 Mar, 09:09 PM Test Summary: 56527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9324

  6. Timo Webler commented on patch set 3 03/20/17, 08:12

    BackendUtility.php:4840

    Why you remove all restrictions and call the old method `enableField`for that?
  7. Christian Kuhn commented on patch set 3 CR -1 03/20/17, 18:17

    BackendUtility.php:4840 Reply

    it is the easiest and most straight forward transition at the moment. guess we should keep that for now to keep the patch as straight as possible. fine with me at the moment.

    MissingRelationsCommand.php:251

    guess we shouldn't feed an empty string here.
  8. Christian Kuhn uploaded patch set 4 03/20/17, 18:21

  9. Manuel Selbach uploaded patch set 5 03/20/17, 18:22

  10. TYPO3com voted on patch set 4 V +1 03/20/17, 18:27 Completed build in 06m 21s on Mon, 20 Mar, 07:27 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9384

  11. TYPO3com voted on patch set 5 V +1 03/20/17, 18:32 Completed build in 09m 56s on Mon, 20 Mar, 07:32 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9385

  12. Manuel Selbach uploaded patch set 6 03/20/17, 18:38

  13. Christian Kuhn voted on patch set 6 CR +1 V +1 03/20/17, 18:47

  14. TYPO3com voted on patch set 6 V +1 03/20/17, 18:59 Completed build in 20m 18s on Mon, 20 Mar, 07:59 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9391

  15. Markus Klein updated the commit message in patch set 7 03/21/17, 07:58

  16. Markus Klein commented on patch set 7 CR -1 03/21/17, 07:59

    Are we talking about a security issue then?? (otherwise please rephrase this sentence!!)
  17. TYPO3com voted on patch set 7 V -1 03/21/17, 08:07 Completed build in 08m 41s on Tue, 21 Mar, 09:07 AM Test Summary: 1 of 56482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9400

  18. Manuel Selbach commented on patch set 7 03/21/17, 09:10

    Reply

    This is not a security issue. Basically it is possible to pass malicious code to the function, if you pass a where statement, which was previously handled insecure. Thus, how should I rephrase? Any suggestion?
  19. Manuel Selbach uploaded patch set 8 03/21/17, 15:46

  20. TYPO3com voted on patch set 8 V +1 03/21/17, 15:55 Completed build in 08m 12s on Tue, 21 Mar, 04:55 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9404

  21. Christian Kuhn voted on patch set 8 CR +1 V +1 03/21/17, 15:58

  22. Anja Leichsenring voted on patch set 8 CR +1 V +1 03/22/17, 14:34

  23. Christian Kuhn voted on patch set 8 CR +2 V +2 03/22/17, 15:38

  24. Gerrit merged patch set 8 03/22/17, 15:38

  25. Benjamin Kott commented on patch set 9 03/22/17, 15:43

    Post -1: Filename of rst file should not contain "::" this makes checkout on Windows filesystem impossible.