52075[TASK] Deprecate BackendUtility::getRecordRaw
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+19 −8
- typo3/sysext/core/Classes/Database/ReferenceIndex.php2+25 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+29 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-80317-DeprecateBackendUtility::getRecordRaw.rstnew+35 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+12 −1
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php1+20 −6
- typo3/sysext/lowlevel/Classes/Command/WorkspaceVersionRecordsCommand.php+15 −1
- typo3/sysext/lowlevel/Classes/CleanerCommand.php+10 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+19 −3
Review log 2028
Show 23 earlier messages
-
Manuel Selbach uploaded patch set 1 03/17/17, 10:34
-
TYPO3com voted on patch set 1 V -1 03/17/17, 10:41 Completed build in 06m 52s on Fri, 17 Mar, 11:41 AM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9252
-
Manuel Selbach uploaded patch set 2 03/17/17, 12:00
-
TYPO3com voted on patch set 2 V +1 03/17/17, 12:09 Completed build in 09m 03s on Fri, 17 Mar, 01:09 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9259
-
Wouter Wolters commented on patch set 2 03/18/17, 15:17
-
Manuel Selbach commented on patch set 2 03/18/17, 19:59
ReferenceIndex.php:230ReplyYou're absolutely right, good catch -
Manuel Selbach uploaded patch set 3 03/18/17, 20:00
-
TYPO3com voted on patch set 3 V +1 03/18/17, 20:09 Completed build in 08m 56s on Sat, 18 Mar, 09:09 PM Test Summary: 56527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9324
-
Timo Webler commented on patch set 3 03/20/17, 08:12
BackendUtility.php:4840Why you remove all restrictions and call the old method `enableField`for that? -
Christian Kuhn commented on patch set 3 CR -1 03/20/17, 18:17
BackendUtility.php:4840Replyit is the easiest and most straight forward transition at the moment. guess we should keep that for now to keep the patch as straight as possible. fine with me at the moment.MissingRelationsCommand.php:251guess we shouldn't feed an empty string here. -
Christian Kuhn uploaded patch set 4 03/20/17, 18:21
-
Manuel Selbach uploaded patch set 5 03/20/17, 18:22
-
TYPO3com voted on patch set 4 V +1 03/20/17, 18:27 Completed build in 06m 21s on Mon, 20 Mar, 07:27 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9384
-
TYPO3com voted on patch set 5 V +1 03/20/17, 18:32 Completed build in 09m 56s on Mon, 20 Mar, 07:32 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9385
-
Manuel Selbach uploaded patch set 6 03/20/17, 18:38
-
Christian Kuhn voted on patch set 6 CR +1 V +1 03/20/17, 18:47
-
TYPO3com voted on patch set 6 V +1 03/20/17, 18:59 Completed build in 20m 18s on Mon, 20 Mar, 07:59 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9391
-
Markus Klein updated the commit message in patch set 7 03/21/17, 07:58
-
Markus Klein commented on patch set 7 CR -1 03/21/17, 07:59
Are we talking about a security issue then?? (otherwise please rephrase this sentence!!) -
TYPO3com voted on patch set 7 V -1 03/21/17, 08:07 Completed build in 08m 41s on Tue, 21 Mar, 09:07 AM Test Summary: 1 of 56482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9400
-
Manuel Selbach commented on patch set 7 03/21/17, 09:10
Reply
This is not a security issue. Basically it is possible to pass malicious code to the function, if you pass a where statement, which was previously handled insecure. Thus, how should I rephrase? Any suggestion? -
Manuel Selbach uploaded patch set 8 03/21/17, 15:46
-
TYPO3com voted on patch set 8 V +1 03/21/17, 15:55 Completed build in 08m 12s on Tue, 21 Mar, 04:55 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9404
-
Christian Kuhn voted on patch set 8 CR +1 V +1 03/21/17, 15:58
-
Anja Leichsenring voted on patch set 8 CR +1 V +1 03/22/17, 14:34
-
Christian Kuhn voted on patch set 8 CR +2 V +2 03/22/17, 15:38
-
Gerrit merged patch set 8 03/22/17, 15:38
-
Benjamin Kott commented on patch set 9 03/22/17, 15:43
Post -1: Filename of rst file should not contain "::" this makes checkout on Windows filesystem impossible.
ReferenceIndex.php:230