Review main Abandoned

52084[TASK] EXT:form - rename 'onSubmit' and 'onBuildingFinished' signals

Ralf Zimmermann CR 0 V 0 Easy +10 −10 updated 03/20/17, 10:29

Commit message

Rename 'onSubmit' and 'onBuildingFinished' signals
to 'afterSubmit' and 'afterBuildingFinished'

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 89

  1. Ralf Zimmermann uploaded patch set 1 03/17/17, 14:43

  2. Mathias Brodala voted on patch set 1 CR +1 03/17/17, 14:44

  3. Ralf Zimmermann voted on patch set 1 CR +1 V +1 03/17/17, 14:45

  4. Ralf Zimmermann commented on patch set 1 03/17/17, 14:47

  5. TYPO3com voted on patch set 1 V +1 03/17/17, 14:50 Completed build in 06m 43s on Fri, 17 Mar, 03:50 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9281

  6. Martin Kutschker voted on patch set 1 CR +1 03/17/17, 21:24

  7. Wouter Wolters voted on patch set 1 CR +1 03/18/17, 14:54

  8. Ralf Zimmermann commented on patch set 1 CR 0 V 0 03/18/17, 16:10

    I prefer this patchset https://review.typo3.org/#/c/52088/ instead of this. Within 52088, the renaming is also done.
  9. Ralf Zimmermann abandoned the change 03/20/17, 10:29