Review main Merged

52089[BUGFIX] Language label and css loading in inline and flex sections

Christian Kuhn CR +2 V +2 Normal +102 −41 updated 03/22/17, 12:05

Commit message

Loading additional stylesheets from elements in inline scope fails if using
'EXT:' syntax, for flex section containers, this was not evaluated at all.
The patch adds code to resolve an EXT: prefix stylesheet file from an element
result array ['stylesheetFiles'] to properly handle loading of this CSS in
JS, and uses it in both inline and flex ajax controller. This issue is easily
reproducible with ext:styleguide 'elements_t3editor', which registers
t3editor.css to load. Without patch, This fail (404) in 'in inline'
't3editor_inline_1' 'Create New'.
Additionally, additional language file handling was not implemented for
flex section container ajax calls, which is also added by the patch,
similar to the solution done in inline ajax.

Review

  • Code review CR +2
    • Susi Moog +2
    • Frank Nägler +1
  • Verified V +2
    • Susi Moog +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 911

  1. Christian Kuhn uploaded patch set 1 03/17/17, 18:03

  2. TYPO3com voted on patch set 1 V +1 03/17/17, 18:10 Completed build in 06m 38s on Fri, 17 Mar, 07:10 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9292

  3. Wouter Wolters voted on patch set 1 CR +1 03/18/17, 15:10

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 03/18/17, 18:36

  5. Frank Nägler commented on patch set 1 CR -1 03/22/17, 10:58

    on it
  6. Christian Kuhn uploaded patch set 2 03/22/17, 10:58

  7. TYPO3com voted on patch set 2 V +1 03/22/17, 11:05 Completed build in 07m 27s on Wed, 22 Mar, 12:05 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9432

  8. Frank Nägler voted on patch set 2 CR +1 03/22/17, 11:26

  9. Frank Nägler voted on patch set 2 V +1 03/22/17, 11:29

  10. Susi Moog voted on patch set 2 CR +2 V +2 03/22/17, 12:05

  11. Gerrit merged patch set 2 03/22/17, 12:05