Review main Merged

52090[TASK] Support valuePicker in colorpicker

Christian Kuhn CR +2 V +2 Easy +27 −0 updated 03/17/17, 22:58

Commit message

Add the 'valuePicker' functionality to the colorpicker. This is useful
for editors to have a series of defaults. A similar configuration worked
in the past based on 'select' wizard.

Example TCA from styleguide master input_37:
    'config' => [
        'type' => 'input',
        'renderType' => 'colorpicker',
        'size' => 10,
        'valuePicker' => [
            'items' => [
                [ 'blue', '#0000FF', ],
                [ 'red', '#FF0000', ],
                [ 'typo3 orange', '#FF8700', ],
            ],
        ],
    ],

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Christian Kuhn +1

Issues 1

Files 3

Review log 1926

Show 1 earlier messages
  1. Christian Kuhn uploaded patch set 1 03/17/17, 18:42

  1. TYPO3com voted on patch set 1 V +1 03/17/17, 18:50 Completed build in 08m 35s on Fri, 17 Mar, 07:50 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9293

  2. Christian Kuhn commented on patch set 1 CR -1 03/17/17, 18:53

    js does not re-initialize at the moment, needs a look by some js engineer.
  3. Anja Leichsenring uploaded patch set 2 03/17/17, 21:40

  4. Anja Leichsenring uploaded patch set 3 03/17/17, 21:45

  5. Anja Leichsenring uploaded patch set 4 03/17/17, 21:47

  6. Frank Nägler commented on patch set 4 CR -1 03/17/17, 21:50

    on it
  7. TYPO3com voted on patch set 2 V +1 03/17/17, 21:50 Completed build in 09m 49s on Fri, 17 Mar, 10:50 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9296

  8. TYPO3com voted on patch set 3 V +1 03/17/17, 21:53 Completed build in 08m 03s on Fri, 17 Mar, 10:53 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9297

  9. TYPO3com voted on patch set 4 V +1 03/17/17, 21:57 Completed build in 10m 17s on Fri, 17 Mar, 10:57 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9298

  10. Frank Nägler uploaded patch set 5 03/17/17, 22:17

  11. Frank Nägler voted on patch set 5 CR +1 V +1 03/17/17, 22:20

  12. Christian Kuhn voted on patch set 5 CR +1 V +1 03/17/17, 22:25

  13. TYPO3com voted on patch set 5 V +1 03/17/17, 22:26 Completed build in 07m 56s on Fri, 17 Mar, 11:26 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9299

  14. Christian Kuhn voted on patch set 5 CR 0 V 0 03/17/17, 22:33

  15. Frank Nägler uploaded patch set 6 03/17/17, 22:38

  16. Frank Nägler voted on patch set 6 CR +1 V +1 03/17/17, 22:40

  17. Christian Kuhn voted on patch set 6 CR +1 V +1 03/17/17, 22:41

  18. TYPO3com voted on patch set 6 V +1 03/17/17, 22:47 Completed build in 08m 07s on Fri, 17 Mar, 11:47 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9300

  19. Frank Nägler uploaded patch set 7 03/17/17, 22:48

  20. Frank Nägler voted on patch set 7 CR +1 V +1 03/17/17, 22:48

  21. Anja Leichsenring voted on patch set 7 CR +1 V +1 03/17/17, 22:50

  22. Christian Kuhn voted on patch set 7 CR +1 V +1 03/17/17, 22:50

  23. Frank Nägler voted on patch set 7 CR +2 V +2 03/17/17, 22:54

  24. Gerrit merged patch set 7 03/17/17, 22:54

  25. TYPO3com commented on patch set 7 03/17/17, 22:58 Completed build in 10m 05s on Fri, 17 Mar, 11:58 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9301