Review TYPO3_7-6 Merged

52106[BUGFIX] DBAL: Ensure correct mysqli resource for admin_get_tables query

Nicole Hummel CR +2 V +2 Easy +2 −1 updated 05/11/17, 15:24

Commit message

The admin_get_tables method tries to fetch all available database tables
from the default connection. But using the native mode, the query is
executed with the $this->lastHandlerKey link which might not be the
default connection. This patch ensures the correct mysqli resource is
used to resolve the database queries.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Elmar Hinz +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Nicole Hummel uploaded patch set 1 03/20/17, 18:02

  2. TYPO3com voted on patch set 1 V +1 03/20/17, 18:06 Completed build in 03m 49s on Mon, 20 Mar, 07:06 PM Test Summary: 38591 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-832

  3. Wouter Wolters voted on patch set 1 CR +1 03/22/17, 18:55

  4. Stefan Neufeind voted on patch set 1 CR +1 05/08/17, 07:20

  5. Elmar Hinz voted on patch set 1 CR +1 05/11/17, 13:03

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 05/11/17, 15:24

  7. Gerrit merged patch set 1 05/11/17, 15:24