52117[BUGFIX] EXT:form - ignore removed form definitions in page module
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Björn Jacob +1
-
Verified V +2
- Frank Nägler +2
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1519
-
Ralf Zimmermann uploaded patch set 1 03/22/17, 09:29
-
Georg Ringer commented on patch set 1 CR -1 03/22/17, 09:34
-
TYPO3com voted on patch set 1 V +1 03/22/17, 09:36 Completed build in 07m 26s on Wed, 22 Mar, 10:36 AM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9424
-
David Gurk commented on patch set 1 CR -1 03/22/17, 09:50
I applied this patch and it doesn't resolve the issue. Here is the error from the logs: Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1471473378: The file "/var/www/web/typo3conf/ext/project/Configuration/Forms/Contact.yaml" does not exist. | TYPO3\CMS\Form\Mvc\Configuration\Exception\NoSuchFileException thrown in file /var/www/vendor/typo3/cms/typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php in line 79. -
Ralf Zimmermann commented on patch set 1 03/22/17, 09:52
Could you please provide a stacktrace? Maybe turn debug mode to on? I can't reproduce this for now -
David Gurk commented on patch set 1 CR +1 03/22/17, 11:16
I done the mistake to test the patch on 8.6.1 and not on master. -
Ralf Zimmermann commented on patch set 1 CR -1 03/22/17, 11:18
I will provide a message like georg mentioned asap -
Ralf Zimmermann uploaded patch set 2 03/22/17, 19:41
-
TYPO3com voted on patch set 2 V +1 03/22/17, 19:47 Completed build in 05m 55s on Wed, 22 Mar, 08:47 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9457
-
Björn Jacob updated the commit message in patch set 3 03/22/17, 21:55
-
Björn Jacob voted on patch set 3 CR +1 V +1 03/22/17, 21:59
-
TYPO3com voted on patch set 3 V +1 03/22/17, 22:05 Completed build in 09m 38s on Wed, 22 Mar, 11:05 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9476
-
Frank Nägler commented on patch set 3 CR -1 03/23/17, 21:47
FormPagePreviewRenderer.php:60top level exceptions should never be catched. which kind of exceptions could be thrown? Catch only specific exceptions if possible. -
Ralf Zimmermann uploaded patch set 4 03/23/17, 22:00
-
TYPO3com voted on patch set 4 V +1 03/23/17, 22:11 Completed build in 11m 19s on Thu, 23 Mar, 11:11 PM Test Summary: 56475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9500
-
Frank Nägler voted on patch set 4 CR +1 V +1 03/23/17, 22:20
-
Björn Jacob voted on patch set 4 CR +1 V +1 03/24/17, 06:52
-
Frank Nägler voted on patch set 4 CR +2 V +2 03/24/17, 08:44
-
Gerrit merged patch set 4 03/24/17, 08:44
FormPagePreviewRenderer.php:67