Review main Merged

52118[TASK] Do not clear constants in CSS Styled Content

Benni Mack CR +2 V +2 Easy +26 −3 updated 03/22/17, 15:38

Commit message

The constants within `styles.content` were cleared
via CSS Styled Content which did not allow to define
any constants before the TypoScript template was
included in that space.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Josef Glatz +1
  • Verified V +2
    • Benjamin Kott +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 03/22/17, 09:34

  2. Benjamin Kott voted on patch set 1 CR +1 V +1 03/22/17, 09:35

  3. TYPO3com voted on patch set 1 V +1 03/22/17, 09:44 Completed build in 09m 34s on Wed, 22 Mar, 10:44 AM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9425

  4. Josef Glatz voted on patch set 1 CR +1 V +1 03/22/17, 11:54

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 03/22/17, 15:38

  6. Gerrit merged patch set 1 03/22/17, 15:38