52119[TASK] Streamline indexed_search template files
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Frank Nägler +1
-
Verified V +2
- Benni Mack +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/indexed_search/Resources/Private/Layouts/Administration.html+2 −0
- typo3/sysext/indexed_search/Resources/Private/Partials/Form.html+96 −110
- typo3/sysext/indexed_search/Resources/Private/Partials/Rules.html+7 −5
- typo3/sysext/indexed_search/Resources/Private/Partials/Searchresult.html+2 −6
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/ExternalDocuments.html+18 −18
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Index.html+18 −17
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Pages.html+18 −17
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html+14 −13
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html+37 −41
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/WordDetail.html+16 −13
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/Form.html+2 −0
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/NoTypoScript.html+3 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/Search.html+4 −7
Review log 1012
-
Benjamin Kott uploaded patch set 1 03/22/17, 10:03
-
TYPO3com voted on patch set 1 V +1 03/22/17, 10:10 Completed build in 06m 48s on Wed, 22 Mar, 11:10 AM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9430
-
Tymoteusz Motylewski commented on patch set 1 03/22/17, 16:23
can you please list the changes in the commit message? -
Benjamin Kott updated the commit message in patch set 2 03/22/17, 19:50
-
TYPO3com voted on patch set 2 V +1 03/22/17, 19:59 Completed build in 09m 25s on Wed, 22 Mar, 08:59 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9458
-
Frank Nägler voted on patch set 2 CR +1 03/22/17, 20:46
-
Frank Nägler voted on patch set 2 V +1 03/22/17, 20:46
-
Tymoteusz Motylewski commented on patch set 2 03/22/17, 22:23
hmm, do we really have to define f: namespace in every file? Haven't Claus saying that this is slowing the stuff? -
Claus Due commented on patch set 2 03/22/17, 22:44
There are arguments both for and against. It's not up to me to decide which one you choose: * Global namespaces do not need to be imported; all that does is cause extra processing and method calls that have no effect (and provides IDE integration if you use XSD). * Using {namespace xyz=XYZ} is slightly more efficient; it then becomes an expression node which both parses and compiles slightly better. For my own opinion: I like minimalist templates especially in the core and would leave the imports out when they aren't necessary for operation. Things that are only necessary for development should not be included in the shipped package - but it's not possible, nor smart at all, to provide two sets of Fluid templates; one for dev and one for production. The impact may be minimal but the code is technically redundant. Imposing it on all sites including production sites seems wrong, imho. The only argument for it, is developer friendliness. PS: There's a lint tool that will validate the syntax against loaded ViewHelper classes - add that to CI if error prevention is the goal. -
Benjamin Kott commented on patch set 2 03/23/17, 00:00
i have no personal feelings in this, but understanding global namespaces for fluid seems (for me) to be a widely spread problem. have a look at https://forge.typo3.org/issues/80393, this is not the first time this was mentioned i am in for every solution but we should deliver with CMS8 a consistend templating language (at least for the templates people used to override). that means we add it to all templates, or we remove it from all frontend related templates. since we are shipping this since 7.6 with fsc people are used to it - but if it has a major performance impact we should remove them and start educating the integrators -
Benni Mack commented on patch set 2 CR +2 V +2 03/28/17, 08:36
we will do it exactly the same as we do in Fluid Styled Content. We need to provide the best way of using Fluid for extension developers, so they know what best practices are... -
Gerrit merged patch set 2 03/28/17, 08:36