Review main Merged

52127[BUGFIX] LocalizationStateSelector with new records

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 03/22/17, 18:53

Commit message

The LocalizationStateSelector field wizard on new, not yet persisted records
casts the ['databaseRow']['uid'] to integer which leads to 0 if the uid is
'NEW1234...'.

Example (wrong) field name in formEngine:
 data[pages_language_overlay][0][l10n_state][subtitle]
Should:
 data[pages_language_overlay][NEW1234][l10n_state][subtitle]

Thus, field wizards values different from default are not stored.
The patch changes the int cast to an htmlspecialchars() to transfer
correct record uid for new records, too.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 03/22/17, 16:57

  2. Christian Kuhn commented on patch set 1 03/22/17, 17:00

    example test: add to typo3/sysext/frontend/Configuration/TCA/pages_language_overlay.php on a simple field (like subtitle) to trigger the wizard. 'behaviour' => [ 'allowLanguageSynchronization' => true, ], create 'alternative page language' from page module for a page -> wizard for that field should appear -> change wizard value -> store -> value lost. apply patch -> chosen value correctly persisted.
  3. Jan Helke voted on patch set 1 CR +1 03/22/17, 17:00

  4. TYPO3com voted on patch set 1 V +1 03/22/17, 17:03 Completed build in 05m 23s on Wed, 22 Mar, 06:03 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9447

  5. Jan Helke voted on patch set 1 V +1 03/22/17, 17:38

  6. Christian Kuhn updated the commit message in patch set 2 03/22/17, 17:45

  7. Jan Helke voted on patch set 2 CR +1 V +1 03/22/17, 17:45

  8. TYPO3com voted on patch set 2 V +1 03/22/17, 18:01 Completed build in 16m 01s on Wed, 22 Mar, 07:01 PM Test Summary: 56473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9452

  9. Wouter Wolters voted on patch set 2 CR +2 V +2 03/22/17, 18:53

  10. Gerrit merged patch set 2 03/22/17, 18:53