52136[BUGFIX] Start click binding only after DOM is ready
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Andreas Kienast +1
- Tabea Oertel +1
-
Verified V +2
- Markus Klein +2
- Tabea Oertel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1416
-
Frank Nägler uploaded patch set 1 03/23/17, 13:47
-
Frank Nägler commented on patch set 1 03/23/17, 13:50
I have a ready backport for 7.6 but will wait until anyone confirm the fix for master. I can't reproduce the issue, but I think I know what is wrong ;) -
TYPO3com voted on patch set 1 V +1 03/23/17, 13:53 Completed build in 05m 48s on Thu, 23 Mar, 02:53 PM Test Summary: 56475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9489
-
Markus Klein updated the commit message in patch set 2 03/23/17, 13:55
-
Markus Klein voted on patch set 2 CR +1 03/23/17, 13:56
-
Markus Klein voted on patch set 2 V +1 03/23/17, 13:57
-
TYPO3com voted on patch set 2 V +1 03/23/17, 14:04 Completed build in 08m 31s on Thu, 23 Mar, 03:04 PM Test Summary: 56475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9490
-
Andreas Kienast voted on patch set 2 CR +1 03/23/17, 14:12
-
Wouter Wolters voted on patch set 2 CR +1 03/23/17, 14:52
-
Tabea Oertel commented on patch set 2 03/23/17, 15:30
I tested the Patch and it does fix the problem. But we should check the existance of the element in javascript too before registering any eventhandler on it. So we need an $selectElement.length check in SelectSingleElement.js. -
Frank Nägler commented on patch set 2 03/23/17, 15:35
thanks for testing Tabea, but we don't need the check. If no icons exists, there will be no binding. no need for an extra check. If you would vote for the patch Markus could merge it, and I can take care of the backport. -
Tabea Oertel commented on patch set 2 03/23/17, 15:59
Its not only the binding. If we would add a simple check on top, we wouldnt have to execute the whole function just to realize that the element isnt even there. -
Markus Klein commented on patch set 2 03/23/17, 23:36
@Tabea: Whatever optimization we can achieve should be done, but please with a different patchset. If you could vote that would be helpful, since you confirmed that it works. Thanks. -
Tabea Oertel voted on patch set 2 CR +1 V +1 03/24/17, 14:23
-
Markus Klein voted on patch set 2 CR +2 V +2 03/24/17, 14:25
-
Gerrit merged patch set 2 03/24/17, 14:25