Review TYPO3_7-6 Merged

52142[BUGFIX] Wrong computed baseURL with FE editing RTE

Jigal van Hemert CR +2 V +2 Easy +2 −2 updated 06/12/17, 12:48

Commit message

Frontend editing button for editing a content now
url encode the return URL. The HTMLAREA baseURL
computation now excludes query parameters and anchor
from the document URL.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Elmar Hinz +1
  • Verified V +2
    • Benni Mack +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 78

  1. Jigal van Hemert uploaded patch set 1 03/24/17, 14:05

  2. TYPO3com voted on patch set 1 V +1 03/24/17, 14:09 Completed build in 03m 49s on Fri, 24 Mar, 03:09 PM Test Summary: 38591 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-838

  3. Benni Mack voted on patch set 1 CR +1 V +1 03/28/17, 07:36

  4. Stefan Neufeind voted on patch set 1 CR +1 05/08/17, 07:19

  5. Elmar Hinz voted on patch set 1 CR +1 05/11/17, 12:47

  6. Riccardo De Contardi commented on patch set 1 V +1 06/12/17, 12:46

    verified on 7.6.18 and Firefox on Windows; tested with config.absRefPrefix, config.baseURL, both, none.
  7. Benni Mack commented on patch set 1 CR +2 V +2 06/12/17, 12:47

    same here.
  8. Gerrit merged patch set 1 06/12/17, 12:48