Review TYPO3_7-6 Merged

52143[BUGFIX] Start click binding only after DOM is ready

Frank Nägler CR +2 V +2 Easy +15 −11 updated 03/24/17, 14:43

Commit message

This patch fixes a loading issue on poor internet connections.
In case of a slow internet connection the icons are not loaded and the
click binding does not work. A DOM ready check should solve the issue.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 1

Review log 68

  1. Frank Nägler uploaded patch set 1 03/24/17, 14:30

  2. TYPO3com voted on patch set 1 V +1 03/24/17, 14:35 Completed build in 04m 51s on Fri, 24 Mar, 03:35 PM Test Summary: 38591 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-839

  3. Markus Klein voted on patch set 1 CR +1 03/24/17, 14:35

  4. Frank Nägler uploaded patch set 2 03/24/17, 14:38

  5. Markus Klein voted on patch set 2 CR +1 V +1 03/24/17, 14:39

  6. Frank Nägler voted on patch set 2 CR +2 V +2 03/24/17, 14:41

  7. Gerrit merged patch set 2 03/24/17, 14:41

  8. TYPO3com commented on patch set 2 03/24/17, 14:43 Completed build in 05m 11s on Fri, 24 Mar, 03:43 PM Test Summary: 38591 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-840