Review main Merged

52144[BUGFIX] Improve rendering of long text

Markus Sommer CR +2 V +2 Easy +14 −3 updated 03/30/17, 21:07

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Markus Sommer uploaded patch set 1 03/24/17, 14:58

  2. Thomas Hohn voted on patch set 1 CR +1 03/24/17, 15:07

  3. TYPO3com voted on patch set 1 V +1 03/24/17, 15:07 Completed build in 09m 33s on Fri, 24 Mar, 04:07 PM Test Summary: 56481 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9516

  4. Georg Ringer voted on patch set 1 CR +1 V +1 03/25/17, 05:58

  5. Frank Nägler commented on patch set 1 03/25/17, 10:07

    1) The tooltip lib is not required, result: tooltip not init ;) (existing issue) 2) The field don't expand anymore, but the content is not readable 3) The tooltip not work here, because a long url will not break to multiple lines and the text is cut-off at the end of the tooltip. I am fine with this current state as it fix a layout problem, but it brings a new issue: The cut-off text. Please create a followup issue for it and link both issues in forge,
  6. Christian Kuhn commented on patch set 1 CR -1 03/25/17, 23:50

    will put this issue into uxw, let's see if the team can come up with something.
  7. Frank Nägler uploaded patch set 2 03/30/17, 20:33

  8. Frank Nägler voted on patch set 2 CR +1 V +1 03/30/17, 20:33

  9. TYPO3com voted on patch set 2 V +1 03/30/17, 20:44 Completed build in 10m 44s on Thu, 30 Mar, 10:44 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9988

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 03/30/17, 21:07

  11. Gerrit merged patch set 2 03/30/17, 21:07