Review main Merged

52146[BUGFIX] Use correct property for images in FrontendUser

Georg Ringer CR +2 V +2 Easy +16 −11 updated 03/28/17, 08:37

Commit message

As the image field has been changed to FAL, also the model must
be adopted.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Nikolai Townsend +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 03/25/17, 09:54

  2. TYPO3com voted on patch set 1 V +1 03/25/17, 10:00 Completed build in 05m 57s on Sat, 25 Mar, 11:00 AM Test Summary: 56505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9522

  3. Wouter Wolters commented on patch set 1 03/25/17, 10:08

    IMO we need to adapt the breaking RST from #74375 with this change mentioned.
  4. Nikolai Townsend commented on patch set 1 V +1 03/26/17, 02:51

    Works for me. I think there is on need to change the RST, when I red the fe_users.image has been changed to FAL I expected that the model is changed to. So this patch is just fulfilling what I expected from the earlier changes anyway.
  5. Benni Mack voted on patch set 1 CR +1 03/26/17, 19:18

  6. Benni Mack voted on patch set 1 V +1 03/27/17, 07:16

  7. Wouter Wolters voted on patch set 1 CR +2 V +2 03/28/17, 08:37

  8. Gerrit merged patch set 1 03/28/17, 08:37