Review main Merged

52153[TASK] Deprecate EXT:lowlevel ArrayBrowser->wrapValue

Benni Mack CR +2 V +2 Easy +36 −1 updated 03/25/17, 22:18

Commit message

The method ArrayBrowser->wrapValue() only does a htmlspecialchars()
call nowadays and can be replaced easily by PHP native functions.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 03/25/17, 17:05

  2. Benni Mack commented on patch set 1 CR -1 03/25/17, 17:08

    RST following
  3. Benni Mack uploaded patch set 2 03/25/17, 17:11

  4. TYPO3com voted on patch set 1 V +1 03/25/17, 17:15 Completed build in 10m 02s on Sat, 25 Mar, 06:15 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9536

  5. TYPO3com voted on patch set 2 V +1 03/25/17, 17:18 Completed build in 06m 51s on Sat, 25 Mar, 06:18 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9538

  6. Oliver Klee voted on patch set 2 CR +1 03/25/17, 20:11

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 03/25/17, 22:17

  8. Gerrit merged patch set 2 03/25/17, 22:18