Review main Merged

52154[BUGFIX] EXT:form - do not wrap in anonymous function

Benni Mack CR +2 V +2 Easy +20 −22 updated 03/25/17, 21:56

Commit message

There are no local variables in ext_tables.php that would
justify having a call_user_func() wrap around the
registration of the Form module.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Patrick Broens +1
  • Verified V +2
    • Christian Kuhn +2
    • Patrick Broens +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 03/25/17, 17:07

  2. TYPO3com voted on patch set 1 V +1 03/25/17, 17:15 Completed build in 07m 37s on Sat, 25 Mar, 06:15 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9537

  3. Patrick Broens voted on patch set 1 CR +1 V +1 03/25/17, 19:15

  4. Oliver Klee voted on patch set 1 CR +1 03/25/17, 20:10

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 03/25/17, 21:56

  6. Gerrit merged patch set 1 03/25/17, 21:56