52173[TASK] Deprecate cliKeys logic and cli_dispatch.phpsh entrypoint
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Console/Application.php+4 −0
- typo3/sysext/backend/Classes/Console/CliRequestHandler.php+4 −0
- typo3/sysext/backend/Resources/Private/Php/cli.php+4 −0
- typo3/sysext/core/Classes/Console/CommandRequestHandler.php3+2 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-80468-CommandLineInterfaceCliKeysAndCli_dispatchphpsh.rstnew+48 −0
- typo3/sysext/extbase/ext_localconf.php+1 −0
- typo3/sysext/lowlevel/ext_localconf.php+1 −0
- typo3/sysext/scheduler/ext_localconf.php+1 −0
- typo3/cli_dispatch.phpsh+2 −1
Review log 1318
-
Benni Mack uploaded patch set 1 03/27/17, 10:13
-
TYPO3com voted on patch set 1 V +1 03/27/17, 10:21 Completed build in 08m 09s on Mon, 27 Mar, 12:21 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9617
-
Mathias Brodala commented on patch set 2 03/27/17, 10:38
Published edit on patch set 1. -
Benni Mack commented on patch set 2 03/27/17, 10:38
This one needs to go in first: https://review.typo3.org/#/c/51886/ -
Mathias Brodala commented on patch set 3 03/27/17, 10:40
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 03/27/17, 10:59 Completed build in 19m 27s on Mon, 27 Mar, 12:59 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9623
-
TYPO3com voted on patch set 2 V +1 03/27/17, 11:00 Completed build in 22m 22s on Mon, 27 Mar, 01:00 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9622
-
Frank Nägler commented on patch set 3 03/27/17, 15:17
CommandRequestHandler.php:77can/should we log a deprecation here? -
Benni Mack commented on patch set 3 03/27/17, 15:24
CommandRequestHandler.php:77Replyjust to print them out shouldn't be a deprecation, if they are called, it should be triggered (which it does) -
Frank Nägler commented on patch set 3 03/27/17, 15:29
CommandRequestHandler.php:77Replyok, as discussed, i will add an info to the output -
Frank Nägler commented on patch set 4 03/27/17, 15:34
Published edit on patch set 3. -
Frank Nägler voted on patch set 4 CR +1 03/27/17, 15:34
-
Frank Nägler commented on patch set 6 03/27/17, 15:35
Published edit on patch set 4. -
TYPO3com voted on patch set 4 V -1 03/27/17, 15:46 Completed build in 11m 44s on Mon, 27 Mar, 05:46 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9657
-
Frank Nägler voted on patch set 6 CR +1 V +1 03/27/17, 15:50
-
TYPO3com voted on patch set 6 V +1 03/27/17, 15:52 Completed build in 17m 19s on Mon, 27 Mar, 05:52 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9658
-
Christian Kuhn voted on patch set 6 CR +2 V +2 03/27/17, 16:13
-
Gerrit merged patch set 6 03/27/17, 16:13