Review main Merged

52173[TASK] Deprecate cliKeys logic and cli_dispatch.phpsh entrypoint

Benni Mack CR +2 V +2 Normal +68 −1 updated 03/27/17, 16:13

Commit message

The way of calling CLI scripts from within TYPO3 via the "cliKeys"
functionality and the typo3/cli_dispatch.phpsh entrypoint have been
superseded by the new Symfony Console integration.

All code related to this functionality has been marked as deprecated.

Calling the CliRequestHandler (which is the main entry point for the
cli_dispatch.phpsh) will trigger a deprecation message warning.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1318

  1. Benni Mack uploaded patch set 1 03/27/17, 10:13

  2. TYPO3com voted on patch set 1 V +1 03/27/17, 10:21 Completed build in 08m 09s on Mon, 27 Mar, 12:21 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9617

  3. Mathias Brodala commented on patch set 2 03/27/17, 10:38

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 03/27/17, 10:38

    This one needs to go in first: https://review.typo3.org/#/c/51886/
  5. Mathias Brodala commented on patch set 3 03/27/17, 10:40

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 03/27/17, 10:59 Completed build in 19m 27s on Mon, 27 Mar, 12:59 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9623

  7. TYPO3com voted on patch set 2 V +1 03/27/17, 11:00 Completed build in 22m 22s on Mon, 27 Mar, 01:00 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9622

  8. Frank Nägler commented on patch set 3 03/27/17, 15:17

    CommandRequestHandler.php:77

    can/should we log a deprecation here?
  9. Benni Mack commented on patch set 3 03/27/17, 15:24

    CommandRequestHandler.php:77 Reply

    just to print them out shouldn't be a deprecation, if they are called, it should be triggered (which it does)
  10. Frank Nägler commented on patch set 3 03/27/17, 15:29

    CommandRequestHandler.php:77 Reply

    ok, as discussed, i will add an info to the output
  11. Frank Nägler commented on patch set 4 03/27/17, 15:34

    Published edit on patch set 3.
  12. Frank Nägler voted on patch set 4 CR +1 03/27/17, 15:34

  13. Frank Nägler commented on patch set 6 03/27/17, 15:35

    Published edit on patch set 4.
  14. TYPO3com voted on patch set 4 V -1 03/27/17, 15:46 Completed build in 11m 44s on Mon, 27 Mar, 05:46 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9657

  15. Frank Nägler voted on patch set 6 CR +1 V +1 03/27/17, 15:50

  16. TYPO3com voted on patch set 6 V +1 03/27/17, 15:52 Completed build in 17m 19s on Mon, 27 Mar, 05:52 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9658

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 03/27/17, 16:13

  18. Gerrit merged patch set 6 03/27/17, 16:13