Review main Merged

52179[TASK] Do not rely on sys_page cache shortcut for fetching TSconfig

Benni Mack CR +2 V +2 Easy +5 −6 updated 03/27/17, 18:35

Commit message

The TypoScript Frontend Controller has a unnecessary dependency
to a static call (which is made non-static !) of PageRepository
which can be done exactly 1:1 by instantiating the cacheManager
and fetching the "cache_hash" cache directly by storing and fetching
the contents itself.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 03/27/17, 13:47

  2. TYPO3com voted on patch set 1 V +1 03/27/17, 14:10 Completed build in 22m 52s on Mon, 27 Mar, 04:10 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9639

  3. Frank Nägler voted on patch set 1 CR +1 03/27/17, 18:16

  4. Andreas Kienast voted on patch set 1 CR +1 03/27/17, 18:21

  5. Frank Nägler voted on patch set 1 V +1 03/27/17, 18:27

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 03/27/17, 18:35

  7. Gerrit merged patch set 1 03/27/17, 18:35