Review main Merged

52184[TASK] Deprecate TSFE->whichWorkspace parameter

Benni Mack CR +2 V +2 Easy +41 −1 updated 03/27/17, 20:44

Commit message

The parameter of the $TSFE->whichWorkspace() method decides
whether the UID of the current workspace should be returned or
the actual "title" of the sys_workspace record.

As this parameter is not in use anymore and clearly makes this function
harder to understand why and when someone could use this, this property
is marked as deprecated.

Instead, fetching the workspace title should happen in the place where it
is needed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
  • Verified V +2
    • Susi Moog +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 03/27/17, 14:13

  2. TYPO3com voted on patch set 1 V +1 03/27/17, 14:25 Completed build in 11m 51s on Mon, 27 Mar, 04:25 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9644

  3. Wouter Wolters commented on patch set 2 03/27/17, 20:17

    Published edit on patch set 1.
  4. Wouter Wolters voted on patch set 2 CR +1 V +1 03/27/17, 20:17

  5. TYPO3com voted on patch set 2 V +1 03/27/17, 20:31 Completed build in 13m 51s on Mon, 27 Mar, 10:31 PM Test Summary: 56511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9692

  6. Susi Moog voted on patch set 2 CR +2 V +2 03/27/17, 20:44

  7. Gerrit merged patch set 2 03/27/17, 20:44