Review main Merged

52185[TASK] Cleanup Localization Charset code

Benni Mack CR +2 V +2 Normal +34 −37 updated 03/27/17, 23:03

Commit message

The protected property "AbstractXmlParser->charset" is set from
the outside but never used anymore in either the abstract class nor
in the subclasses.

The protected method "getCharset()" is basically useless:
a) it's never called or in use
b) it has nothing to do with the XmlParser as it does not work
with any properties / functionalities of the XmlParser itself.

The protected method "initialize()" is called solely in the
contructor which can be dealt with directly in the constructor
(that's what a constructor is there for).

The third parameter $charset within getParsedData() is
now not needed anymore within the Parsers, as all expect
UTF-8 for files.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Jigal van Hemert +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack uploaded patch set 1 03/27/17, 14:27

  2. TYPO3com voted on patch set 1 V +1 03/27/17, 14:37 Completed build in 08m 59s on Mon, 27 Mar, 04:37 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9646

  3. Wouter Wolters commented on patch set 2 03/27/17, 20:08

    Published edit on patch set 1.
  4. Wouter Wolters voted on patch set 2 CR +1 V +1 03/27/17, 20:08

  5. TYPO3com voted on patch set 2 V +1 03/27/17, 20:22 Completed build in 14m 15s on Mon, 27 Mar, 10:22 PM Test Summary: 56511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9690

  6. Jigal van Hemert voted on patch set 2 CR +1 V +1 03/27/17, 21:18

  7. Benni Mack voted on patch set 2 CR +2 V +2 03/27/17, 23:03

  8. Gerrit merged patch set 2 03/27/17, 23:03