52197[TASK] Add data attributes in backend toolbar and menu components
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mathias Schreiber +1
-
Verified V +2
- Frank Nägler +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/BackendController.php3+8 −2
- typo3/sysext/backend/Classes/Template/Components/Menu/Menu.php4+12 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+8 −2
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/Menus/SelectBoxJumpMenu.html+2 −2
Review log 2230
Show 35 earlier messages
-
Thomas Deuling uploaded patch set 1 03/27/17, 20:35
-
Jan Helke updated the commit message in patch set 2 03/27/17, 20:38
-
Wouter Wolters commented on patch set 2 03/27/17, 20:39
-
TYPO3com voted on patch set 1 V +1 03/27/17, 20:53 Completed build in 17m 36s on Mon, 27 Mar, 10:53 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9695
-
TYPO3com voted on patch set 2 V +1 03/27/17, 20:58 Completed build in 19m 26s on Mon, 27 Mar, 10:58 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9697
-
Thomas Deuling commented on patch set 2 04/03/17, 09:19
> (1 comment) $className would be for example id="typo3-cms-backend-backend-toolbaritems-shortcuttoolbaritem", which is extremely long. An identifier like data-toolbar-identifier="shortcut-toolbar-item" is absolutely enough for our requirements. -
Thomas Deuling uploaded patch set 3 05/20/17, 10:20
-
Thomas Deuling updated the commit message in patch set 4 05/20/17, 10:31
-
TYPO3com voted on patch set 4 V -1 05/20/17, 10:36 Completed build in 05m 29s on Sat, 20 May, 12:36 PM Test Summary: 7 of 55888 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11608
-
Oliver Klee commented on patch set 4 05/20/17, 10:42
Menu.php:123As this is a new method, can we have return type hinting (string)? -
TYPO3com voted on patch set 3 V -1 05/20/17, 10:44 Completed build in 24m 06s on Sat, 20 May, 12:44 PM Test Summary: 1 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11605
-
TYPO3com commented on patch set 3 05/20/17, 13:01 Completed build in 3h 04m 41s on Sat, 20 May, 03:01 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11605
-
Jan Helke uploaded patch set 5 05/20/17, 13:07
-
Jan Helke commented on patch set 5 CR +1 V +1 05/20/17, 13:08
Menu.php:123ReplyDone -
TYPO3com voted on patch set 5 V +1 05/20/17, 13:16 Completed build in 08m 18s on Sat, 20 May, 03:16 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11614
-
Christian Kuhn commented on patch set 5 05/22/17, 16:57
BackendController.php:480not a big fan ... isn't there some different solution? -
Frank Nägler commented on patch set 5 CR -1 06/05/17, 16:33
BackendController.php:480ReplyI am sure you can get the same result with this code: $shortName = array_pop(GeneralUtility::trimExplode('/', $className)); I am with Christian here, please no ReflectionClass to get the classname. -
Benni Mack commented on patch set 5 11/30/17, 15:20
ping. how are we going to continue here? I will abandon this patch in a few days otherwise (does not work in its current state anymore, anyways) -
Thomas Deuling commented on patch set 5 12/04/17, 07:07
Because of a lot of work and family I don't have the time to continue this work. Maybe someone other can continue this or we kick it. When you say, that this won't work anymore, it's ok to remove it. -
Andreas Kienast commented on patch set 5 12/04/17, 07:37
I may take a look the next days -
Andreas Kienast uploaded patch set 6 12/04/17, 20:21
-
Andreas Kienast uploaded patch set 7 12/04/17, 20:25
-
TYPO3com voted on patch set 6 V +1 12/04/17, 20:32 Completed build in 10m 20s on Mon, 4 Dec, 09:32 PM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17200
-
TYPO3com voted on patch set 7 V +1 12/04/17, 20:35 Completed build in 10m 07s on Mon, 4 Dec, 09:35 PM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17201
-
Georg Ringer commented on patch set 7 12/05/17, 14:02
Menu.php:123is this method even used? -
Andreas Kienast commented on patch set 7 12/05/17, 15:09
Menu.php:123ReplyI think that's some magic for SelectBoxJumpMenu.html (there is a menu.dataIdentifier) -
Mathias Schreiber voted on patch set 7 V +1 CR +1 02/04/18, 14:30
-
Frank Nägler voted on patch set 7 V +2 CR +2 02/23/18, 14:23
-
Frank Nägler merged patch set 8 02/23/18, 14:24
-
Frank Nägler commented on patch set 8 02/23/18, 14:24
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8a56b80a0fca6d5ca9ca01ddfb97378d87a64b6b
BackendController.php:527