Review main Merged

52197[TASK] Add data attributes in backend toolbar and menu components

Thomas Deuling CR +2 V +2 Easy +32 −8 updated 02/23/18, 14:24

Commit message

Add data attributes in backend toolbar and backend menu components,
to have general identifier for binding guided tours popover and
more features that can be based on this.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2230

Show 35 earlier messages
  1. Thomas Deuling uploaded patch set 1 03/27/17, 20:35

  2. Jan Helke updated the commit message in patch set 2 03/27/17, 20:38

  3. Wouter Wolters commented on patch set 2 03/27/17, 20:39

    BackendController.php:527

    why not use $className here?
  4. TYPO3com voted on patch set 1 V +1 03/27/17, 20:53 Completed build in 17m 36s on Mon, 27 Mar, 10:53 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9695

  5. TYPO3com voted on patch set 2 V +1 03/27/17, 20:58 Completed build in 19m 26s on Mon, 27 Mar, 10:58 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9697

  1. Thomas Deuling commented on patch set 2 04/03/17, 09:19

    > (1 comment) $className would be for example id="typo3-cms-backend-backend-toolbaritems-shortcuttoolbaritem", which is extremely long. An identifier like data-toolbar-identifier="shortcut-toolbar-item" is absolutely enough for our requirements.
  2. Thomas Deuling uploaded patch set 3 05/20/17, 10:20

  3. Thomas Deuling updated the commit message in patch set 4 05/20/17, 10:31

  4. TYPO3com voted on patch set 4 V -1 05/20/17, 10:36 Completed build in 05m 29s on Sat, 20 May, 12:36 PM Test Summary: 7 of 55888 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11608

  5. Oliver Klee commented on patch set 4 05/20/17, 10:42

    Menu.php:123

    As this is a new method, can we have return type hinting (string)?
  6. TYPO3com voted on patch set 3 V -1 05/20/17, 10:44 Completed build in 24m 06s on Sat, 20 May, 12:44 PM Test Summary: 1 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11605

  7. TYPO3com commented on patch set 3 05/20/17, 13:01 Completed build in 3h 04m 41s on Sat, 20 May, 03:01 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11605

  8. Jan Helke uploaded patch set 5 05/20/17, 13:07

  9. Jan Helke commented on patch set 5 CR +1 V +1 05/20/17, 13:08

    Menu.php:123 Reply

    Done
  10. TYPO3com voted on patch set 5 V +1 05/20/17, 13:16 Completed build in 08m 18s on Sat, 20 May, 03:16 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11614

  11. Christian Kuhn commented on patch set 5 05/22/17, 16:57

    BackendController.php:480

    not a big fan ... isn't there some different solution?
  12. Frank Nägler commented on patch set 5 CR -1 06/05/17, 16:33

    BackendController.php:480 Reply

    I am sure you can get the same result with this code: $shortName = array_pop(GeneralUtility::trimExplode('/', $className)); I am with Christian here, please no ReflectionClass to get the classname.
  13. Benni Mack commented on patch set 5 11/30/17, 15:20

    ping. how are we going to continue here? I will abandon this patch in a few days otherwise (does not work in its current state anymore, anyways)
  14. Thomas Deuling commented on patch set 5 12/04/17, 07:07

    Because of a lot of work and family I don't have the time to continue this work. Maybe someone other can continue this or we kick it. When you say, that this won't work anymore, it's ok to remove it.
  15. Andreas Kienast commented on patch set 5 12/04/17, 07:37

    I may take a look the next days
  16. Andreas Kienast uploaded patch set 6 12/04/17, 20:21

  17. Andreas Kienast uploaded patch set 7 12/04/17, 20:25

  18. TYPO3com voted on patch set 6 V +1 12/04/17, 20:32 Completed build in 10m 20s on Mon, 4 Dec, 09:32 PM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17200

  19. TYPO3com voted on patch set 7 V +1 12/04/17, 20:35 Completed build in 10m 07s on Mon, 4 Dec, 09:35 PM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17201

  20. Georg Ringer commented on patch set 7 12/05/17, 14:02

    Menu.php:123

    is this method even used?
  21. Andreas Kienast commented on patch set 7 12/05/17, 15:09

    Menu.php:123 Reply

    I think that's some magic for SelectBoxJumpMenu.html (there is a menu.dataIdentifier)
  22. Mathias Schreiber voted on patch set 7 V +1 CR +1 02/04/18, 14:30

  23. Frank Nägler voted on patch set 7 V +2 CR +2 02/23/18, 14:23

  24. Frank Nägler merged patch set 8 02/23/18, 14:24

  25. Frank Nägler commented on patch set 8 02/23/18, 14:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8a56b80a0fca6d5ca9ca01ddfb97378d87a64b6b