Review main Merged

52199[BUGFIX] Ensure module menu is correctly closed after click on overlay

Benjamin Kott CR +2 V +2 Easy +9 −7 updated 03/28/17, 10:36

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 1

Review log 912

  1. Benjamin Kott uploaded patch set 1 03/27/17, 20:55

  2. TYPO3com voted on patch set 1 V +1 03/27/17, 21:22 Completed build in 26m 21s on Mon, 27 Mar, 11:22 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9702

  3. Riccardo De Contardi voted on patch set 1 V +1 03/27/17, 21:44

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 03/28/17, 09:50

  5. Markus Klein commented on patch set 1 CR -1 03/28/17, 09:55

    ModuleMenu.js:133

    this is weird... can we ensure that collapse is a bool everytime?
  6. Markus Klein uploaded patch set 2 03/28/17, 09:58

  7. TYPO3com voted on patch set 2 V +1 03/28/17, 10:12 Completed build in 13m 43s on Tue, 28 Mar, 12:12 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9743

  8. Markus Klein uploaded patch set 3 03/28/17, 10:21

  9. Markus Klein voted on patch set 3 CR +1 V +1 03/28/17, 10:22

  10. Frank Nägler voted on patch set 3 CR +2 V +2 03/28/17, 10:31

  11. Gerrit merged patch set 3 03/28/17, 10:32

  12. TYPO3com commented on patch set 3 03/28/17, 10:36 Completed build in 15m 00s on Tue, 28 Mar, 12:36 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9749