Review main Merged

52201[TASK] Remove deprecated localizationMode setting for file fields

Oliver Hader CR +2 V +2 Easy +0 −7 updated 03/28/17, 18:28

Commit message

The current behavior for file fields using TCA type inline is configured
to use localizationMode=select, which is deprecated. Actually files have
been copied along during the localization of the parent record - and
files can then be defined independently for the default language record
and in the translated record. The localizationMode synchronization
behavior was disabled in the user-interface.

With this change the default core behavior will stay the same. If the
localization buttons would have been enabled individually, this now can
be done with the more specific allowLanguageSynchronization feature.

Review

  • Code review CR +2
    • Benni Mack +2
    • Thomas Hohn +1
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Thomas Hohn +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Oliver Hader uploaded patch set 1 03/27/17, 22:01

  2. Oliver Hader updated the commit message in patch set 2 03/27/17, 22:03

  3. Wouter Wolters voted on patch set 2 CR +1 03/27/17, 22:05

  4. TYPO3com voted on patch set 1 V +1 03/27/17, 22:14 Completed build in 13m 05s on Tue, 28 Mar, 12:14 AM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9710

  5. TYPO3com voted on patch set 2 V +1 03/27/17, 22:20 Completed build in 16m 14s on Tue, 28 Mar, 12:20 AM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9712

  6. Georg Ringer voted on patch set 2 CR +1 V +1 03/28/17, 07:16

  7. Thomas Hohn voted on patch set 2 CR +1 V +1 03/28/17, 10:56

  8. Benni Mack voted on patch set 2 CR +2 V +2 03/28/17, 18:28

  9. Gerrit merged patch set 2 03/28/17, 18:28