Review main Merged

52209[TASK] Deprecate AbstractFunctionModule->incLocalLang()

Benni Mack CR +2 V +2 Normal +48 −3 updated 03/28/17, 12:31

Commit message

Loading a locallang.xlf inside the abstract function module now uses the regular
$GLOBALS['LANG']->includeLLFile() of the current file, instead of doing a manual
check on .xml and .php extensions, which the LanguageService/LanguageFactory
is taking care of anyway.

The PHP method incLocalLang() and the now not necessarily needed $thisPath
are therefore marked as deprecated.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 812

  1. Benni Mack uploaded patch set 1 03/28/17, 10:17

  2. TYPO3com voted on patch set 1 V -1 03/28/17, 10:17 Completed build in 05s on Tue, 28 Mar, 12:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9748

  3. TYPO3com commented on patch set 1 03/28/17, 10:18 Completed build in 58s on Tue, 28 Mar, 12:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9748

  4. Benni Mack uploaded patch set 2 03/28/17, 10:25

  5. Frank Nägler voted on patch set 2 CR +1 V +1 03/28/17, 10:36

  6. TYPO3com voted on patch set 2 V +1 03/28/17, 10:42 Completed build in 16m 36s on Tue, 28 Mar, 12:42 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9750

  7. Georg Ringer commented on patch set 2 CR -1 03/28/17, 10:52

    AbstractFunctionModule.php:208

    remoed > removed

    AbstractFunctionModule.php:219

    i would move the log entry before the if statement.
  8. Benni Mack commented on patch set 3 03/28/17, 11:18

    Published edit on patch set 2.
  9. Wouter Wolters voted on patch set 3 CR +1 V +1 03/28/17, 11:24

  10. TYPO3com voted on patch set 3 V +1 03/28/17, 11:29 Completed build in 11m 04s on Tue, 28 Mar, 01:29 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9761

  11. Georg Ringer voted on patch set 3 CR +2 V +2 03/28/17, 12:31

  12. Gerrit merged patch set 3 03/28/17, 12:31