52212[TASK] Deprecate GraphicalFunctions->tempPath and createTempSubDir()
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php1+8 −5
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-80514-GraphicalFunctions-tempPathAndCreateTempSubDir.rstnew+34 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/GraphicalMenuContentObject.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/ImageMenuContentObject.php+2 −2
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+3 −3
- typo3/sysext/install/Classes/Controller/Action/Tool/TestSetup.php+1 −1
Review log 1215
-
Benni Mack uploaded patch set 1 03/28/17, 11:02
-
Thomas Hohn voted on patch set 1 CR +1 03/28/17, 11:04
-
TYPO3com voted on patch set 1 V +1 03/28/17, 11:14 Completed build in 11m 39s on Tue, 28 Mar, 01:14 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9758
-
Wouter Wolters voted on patch set 1 CR +1 03/28/17, 11:26
-
Georg Ringer voted on patch set 1 CR +1 V +1 03/28/17, 12:32
-
Christian Kuhn commented on patch set 1 CR -1 03/28/17, 16:07
-
Benni Mack uploaded patch set 2 03/28/17, 17:11
-
TYPO3com voted on patch set 2 V +1 03/28/17, 17:20 Completed build in 08m 38s on Tue, 28 Mar, 07:20 PM Test Summary: 56447 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9809
-
Christian Kuhn commented on patch set 2 CR -1 03/28/17, 17:34
install tool -> test setup -> write gif and png Image generation failed ImageMagick / GraphicsMagick handling is enabled, but the execute command returned an error. Please check your settings, especially ['GFX']['processor_path'] and ['GFX']['processor_path_lzw'] and ensure Ghostscript is installed on your server. -
Benni Mack uploaded patch set 3 03/28/17, 19:27
-
TYPO3com voted on patch set 3 V +1 03/28/17, 19:36 Completed build in 08m 06s on Tue, 28 Mar, 09:36 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9822
-
Frank Nägler voted on patch set 3 CR +1 V +1 03/28/17, 20:22
-
Wouter Wolters voted on patch set 3 CR +1 03/28/17, 20:24
-
Christian Kuhn voted on patch set 3 CR +2 V +2 03/28/17, 21:18
-
Gerrit merged patch set 3 03/28/17, 21:18
GraphicalFunctions.php:216