Review main Merged

52218[TASK] Use ajax call in Install tool 'clear all cache'

Marc Wessels CR +2 V +2 Hard +226 −34 updated 03/28/17, 21:13

Commit message

The 'clear all cache' buttons is switche to an ajax action
to be more conveniently used.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 1116

  1. Marc Wessels uploaded patch set 1 03/28/17, 15:36

  2. TYPO3com voted on patch set 1 V -1 03/28/17, 15:45 Completed build in 09m 21s on Tue, 28 Mar, 05:45 PM Test Summary: 56447 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9794

  3. Marc Wessels uploaded patch set 2 03/28/17, 15:50

  4. TYPO3com voted on patch set 2 V +1 03/28/17, 16:03 Completed build in 12m 20s on Tue, 28 Mar, 06:03 PM Test Summary: 56447 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9795

  5. Wouter Wolters commented on patch set 2 03/28/17, 18:09

    Install.js:100

    mixed indentation, we use tab as indentation.

    Install.js:113

    commented code, can this be removed?

    Install.js:148

    space after if

    Install.js:149

    same here

    Install.js:152

    remove this comment?

    Install.js:929

    mixed indentation here too.
  6. Marc Wessels uploaded patch set 3 03/28/17, 20:46

  7. Christian Kuhn uploaded patch set 4 03/28/17, 20:53

  8. Frank Nägler commented on patch set 3 03/28/17, 20:54

    ClearAllCache.html:26

    please tabs, see editorconfig ;)

    Install.js:926

    mixed, please tabs
  9. Frank Nägler commented on patch set 4 CR -1 03/28/17, 20:55

    ClearAllCache.html:26

    tabs please

    Install.js:926

    tabs please
  10. TYPO3com voted on patch set 3 V +1 03/28/17, 20:56 Completed build in 10m 08s on Tue, 28 Mar, 10:56 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9833

  11. Christian Kuhn uploaded patch set 5 03/28/17, 20:57

  12. Christian Kuhn voted on patch set 5 CR +1 V +1 03/28/17, 20:59

  13. TYPO3com voted on patch set 4 V +1 03/28/17, 21:10 Completed build in 16m 17s on Tue, 28 Mar, 11:10 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9837

  14. Frank Nägler voted on patch set 5 CR +2 V +2 03/28/17, 21:12

  15. Gerrit merged patch set 5 03/28/17, 21:12

  16. TYPO3com commented on patch set 5 03/28/17, 21:13 Completed build in 15m 54s on Tue, 28 Mar, 11:13 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9838