Review main Merged

52225[FEATURE] Store recent su’ed users and render quicklinks in user menu

Andreas Kienast CR +2 V +2 Normal +177 −2 updated 05/08/17, 08:38

Commit message

When a backend user with admin privileges switches to another user, the
entered user is now stored in the uc. The users stored in this list will
be rendered into the user menu to allow quick switching to the recent
users.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Henrik Elsner +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2535

Show 510 earlier messages
  1. Andreas Kienast uploaded patch set 1 03/28/17, 20:53

  2. Andreas Kienast uploaded patch set 2 03/28/17, 20:57

  3. TYPO3com voted on patch set 1 V +1 03/28/17, 21:09 Completed build in 16m 06s on Tue, 28 Mar, 11:09 PM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9836

  4. TYPO3com voted on patch set 2 V +1 03/28/17, 21:20 Completed build in 23m 07s on Tue, 28 Mar, 11:20 PM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9839

  5. Andreas Kienast uploaded patch set 3 03/30/17, 17:42

  6. TYPO3com voted on patch set 3 V -1 03/30/17, 17:42 Completed build in 06s on Thu, 30 Mar, 07:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9970

  7. Andreas Kienast uploaded patch set 4 03/30/17, 19:06

  8. TYPO3com voted on patch set 4 V -1 03/30/17, 19:18 Completed build in 11m 13s on Thu, 30 Mar, 09:18 PM Test Summary: 1 of 56552 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9975

  9. TYPO3com commented on patch set 4 03/30/17, 19:23 Completed build in 27m 28s on Thu, 30 Mar, 09:23 PM Test Summary: 1 of 56552 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9975

  10. Andreas Kienast uploaded patch set 5 03/30/17, 19:37

  1. TYPO3com voted on patch set 5 V +1 03/30/17, 19:45 Completed build in 08m 28s on Thu, 30 Mar, 09:45 PM Test Summary: 56543 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9980

  2. Andreas Kienast uploaded patch set 6 04/07/17, 13:27

  3. TYPO3com voted on patch set 6 V +1 04/07/17, 13:38 Completed build in 11m 21s on Fri, 7 Apr, 03:38 PM Test Summary: 56642 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10367

  4. Henrik Elsner commented on patch set 6 04/19/17, 09:14

    not completely finished - but looks good and works

    locallang.xlf:23

    SU'ed users?

    UserToolbarItemDropDown.html:28

    Not working currently

    UserToolbarItemDropDown.html:36

    f:translate also not working

    UserToolbarItemDropDown.html:40

    much space in frontend - could be better, but no must have

    BackendUserController.php:269

    should be 3 now - i would comment that it's defined by RECENT_USERS_LIMIT without a direct number
  5. Andreas Kienast commented on patch set 6 04/19/17, 09:17

    locallang.xlf:23 Reply

    SU is the short form of "switch user" - if you have a better label for that, feel free :)

    UserToolbarItemDropDown.html:28 Reply

    You have to clear your system caches of TYPO3 to see the _new_ label.

    UserToolbarItemDropDown.html:36 Reply

    See above

    BackendUserController.php:269 Reply

    True, sounds good
  6. Henrik Elsner uploaded patch set 7 04/19/17, 09:23

  7. Henrik Elsner voted on patch set 7 CR +1 V +1 04/19/17, 09:25

  8. TYPO3com voted on patch set 7 V +1 04/19/17, 09:29 Completed build in 06m 04s on Wed, 19 Apr, 11:29 AM Test Summary: 56216 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10700

  9. Riccardo De Contardi commented on patch set 7 V +1 04/19/17, 14:58

    Functionality is nice, but without a label or something else that explains why those users are in the user menu, it becomes difficult to guess their purpose :) Suggestions: 1) add a label ("quick switch to..."?) or 2) add a tooltip on hover ("quick switch to this user" ?)
  10. Riccardo De Contardi commented on patch set 7 04/19/17, 15:00

    Forget it, I forgot to clear the cache to show the new label :)
  11. Thomas Hohn commented on patch set 7 CR +1 V +1 04/26/17, 10:49

    Nice feature ;-)
  12. Tymoteusz Motylewski commented on patch set 7 V +1 05/05/17, 12:11

    works great, not sure about the naming `switchUserMostRecent` though
  13. Tymoteusz Motylewski commented on patch set 7 CR -1 05/05/17, 13:34

    will publish a new patchset
  14. Tymoteusz Motylewski uploaded patch set 8 05/05/17, 13:42

  15. TYPO3com voted on patch set 8 V +1 05/05/17, 13:47 Completed build in 05m 32s on Fri, 5 May, 03:47 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11228

  16. Henrik Elsner voted on patch set 8 CR +1 V +1 05/05/17, 13:49

  17. Tymoteusz Motylewski voted on patch set 8 CR +1 V +1 05/05/17, 13:52

  18. Oliver Klee commented on patch set 8 05/05/17, 13:54

    UserToolbarItem.php:74

    Can't we use foreach here? Or am I missing something?

    BackendUserController.php:31

    BackendUserController.php:272

    For the @return annotation, there usually is no variable name.

    BackendUserController.php:276

    These are not the users, but their UIDs. I propose using the name $latestUserUids instead.

    BackendUserControllerTest.php:2

    strict mode, please

    BackendUserControllerTest.php:43

    I like these two method names. <3
  19. Tymoteusz Motylewski commented on patch set 8 CR -1 05/05/17, 14:16

    will push an update
  20. Tymoteusz Motylewski uploaded patch set 9 05/05/17, 15:52

  21. Tymoteusz Motylewski commented on patch set 9 05/05/17, 15:53

    fixed issues reported by Oliver
  22. TYPO3com voted on patch set 9 V +1 05/05/17, 15:58 Completed build in 05m 53s on Fri, 5 May, 05:58 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11239

  23. Henrik Elsner voted on patch set 9 CR +1 V +1 05/08/17, 07:30

  24. Tymoteusz Motylewski voted on patch set 9 CR +2 V +2 05/08/17, 08:38

  25. Gerrit merged patch set 9 05/08/17, 08:38