52245[TASK] Remove change 'encryption key' and 'site name' from Install Tool
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Frank Nägler +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Important-80553-SimplifyImportantActionsInInstallTool.rst2new+19 −0
- typo3/sysext/install/Classes/Controller/Action/Tool/ImportantActions.php+0 −53
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/ChangeSiteName.htmldeleted+0 −17
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/SetNewEncryptionKey.htmldeleted+0 −11
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/ImportantActions.html+0 −6
Review log 2125
-
Marc Wessels uploaded patch set 1 03/29/17, 12:31
-
Mathias Brodala commented on patch set 1 03/29/17, 12:35
Uhm, why are these not needed anymore? Changing the site name is easy but generating a new encryption key? -
TYPO3com voted on patch set 1 V -1 03/29/17, 12:41 Completed build in 09m 56s on Wed, 29 Mar, 02:41 PM Test Summary: 3 of 56528 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9891
-
Marc Wessels commented on patch set 1 03/29/17, 12:52
We thougt about this yesterday and decided that these two sections are not used by the users. The sitename could be changed also in "All configuration" and this function is not important, so in this section it is wrong. The encryption key is generated while installing the system and should not be changed by a user. -
Marc Wessels uploaded patch set 2 03/29/17, 12:55
-
Mathias Brodala commented on patch set 1 03/29/17, 12:56
> We thougt about this yesterday and decided Where exactly? :-) Not on https://decisions.typo3.org/ as it seems. > that these two sections > are not used by the users. > The sitename could be changed also in "All configuration" and this > function is not important, so in this section it is wrong. OK, I'm fine with this. > The > encryption key is generated while installing the system and should > not be changed by a user. But what about other cases like e.g. the first deployment to a new server. You'll need to generate a new encryption key for every server which is one case where we use this function. -
Mathias Brodala commented on patch set 2 V -1 03/29/17, 12:57
Blocking this until everything is cleared up. -
TYPO3com voted on patch set 2 V +1 03/29/17, 13:15 Completed build in 19m 46s on Wed, 29 Mar, 03:15 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9897
-
Christian Kuhn uploaded patch set 3 03/29/17, 14:06
-
Christian Kuhn commented on patch set 3 CR +1 V +1 03/29/17, 14:11
Hey Mathias, the team from UXW who are working hard on install tool things is currently restructuring the modules of the tool. Removing the two sections is in-line with what they came up with. I think we agree that 'site name' is entirely useless in 'important actions'. for 'encryption key': the setting is risky in the first place, on running instances, this is never set to something else. If that button is used once during initial-deployment, this is more a deployment issue than a regular install tool task and should be done within deployment, then. Combining "commits hazard", "used never" and "if used, should be dealt with differently", the team says "get rid of it from the casual interface". I think that is a good choice and solution. -
Mathias Brodala commented on patch set 3 03/29/17, 14:14
> for 'encryption key': the setting is risky in the first place, on > running instances, this is never set to something else. If that > button is used once during initial-deployment, this is more a > deployment issue than a regular install tool task and should be > done within deployment, then. Combining "commits hazard", "used > never" and "if used, should be dealt with differently", the team > says "get rid of it from the casual interface". I think that is a > good choice and solution. I'm generally fine with this but the question remains: how should one generate a new encryption key for a new server? I see that the implementation is very simple in SilentConfigurationUpgradeService::generateEncryptionKeyIfNeeded(), so I guess I'll just have to add a command for this. -
TYPO3com voted on patch set 3 V +1 03/29/17, 14:15 Completed build in 08m 58s on Wed, 29 Mar, 04:15 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9907
-
Frank Nägler voted on patch set 3 CR +1 V +1 03/29/17, 14:15
-
Georg Ringer commented on patch set 3 CR -1 03/29/17, 14:15
we need an important rst for that and I don't know why the sitename should be removed, there is no other place to set that. same for the encryption key... also something like removing all processed files can do hazard to a big site, same as changing imagemagick oder changing the db credentials ... -
Christian Kuhn commented on patch set 3 03/29/17, 14:16
yeah. if you automate that during initial deployment for your project, the solution is a one-liner. should be rather easy to achieve i guess. -
Frank Nägler commented on patch set 3 03/29/17, 15:25
@georg: > we need an important rst for that I don't think we need a rst for this, but anyway this should not be the big deal. > and I don't know why the sitename should be removed, there is no other place to set that. same for the encryption key... That is wrong, you can change both in All Configuration > also something like removing all processed files can do hazard to a big site, same as changing imagemagick oder changing the db credentials ... We have here a very good team at the UXW which work on a complete refactoring, e.g. the new concept is to have only four main categories instead of the 10 we have now. This patch is only the first in this area. -
Benni Mack commented on patch set 3 03/29/17, 16:00
Yeah, I agree. an important rst file makes sense. The nice thing about "change encryption key" is that a random one is generated for you - maybe we can just move that functionality into All Configuration. However, I don't recall any good reason why Site Name cannot be simply changed in All Configuration. "It's always been there". Since TYPO3 3.x. But we've changed the installation process multiple times since then, with the option to set admin username and sitename during installation which makes it more prominent than having it in "Important Actions". Both topics (Encryption Key and Changing Site Name) I don't know why it should be kept in "Important Actions". Seems like the "Important Actions" became a lot in the last versions, so there are quite a lot of "Important" things now. That is really unintuitive for new people. -
Georg Ringer commented on patch set 3 CR 0 03/29/17, 16:53
ok sorry forgot that there is the all configuration section as well. rst is because people are used to it and will search for it on the common place - that's all -
Georg Ringer uploaded patch set 4 03/30/17, 03:20
-
TYPO3com voted on patch set 4 V +1 03/30/17, 03:30 Completed build in 10m 35s on Thu, 30 Mar, 05:30 AM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9933
-
Georg Ringer voted on patch set 4 CR +1 V +1 03/30/17, 06:40
-
Mathias Brodala commented on patch set 4 03/30/17, 07:11
Important-80553-SimplifyImportantActionsInInstallTool.rst:4I'd suggest to be more specific here aka "Remove site name / encryption key change actions"Important-80553-SimplifyImportantActionsInInstallTool.rst:17While that holds true for the site name we should at least add a statement for the encryption key. -
Frank Nägler commented on patch set 4 CR +1 V +1 03/30/17, 08:59
I think the RST is fine, it contains all informations and the upcoming install tool changes will change the whole install tool and will be more intuitiv. -
Benni Mack commented on patch set 4 CR +2 V +2 03/30/17, 19:37
encryption key random key generation will be re-added separately. -
Gerrit merged patch set 4 03/30/17, 19:37