52250[FEATURE] Add support to native SQL time column type
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Susi Moog +1
-
Verified V +2
- Markus Klein +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php4+4 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php2+18 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php4+24 −10
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+50 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+18 −0
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+20 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+28 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-80557-AddSupportForNativeSQLTimeColumnType.rstnew+25 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+4 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php1+13 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −1
Review log 3959
Show 2234 earlier messages
-
Eric Chavaillaz uploaded patch set 1 03/29/17, 14:49
-
Mathias Brodala commented on patch set 1 03/29/17, 14:55
DataHandler.php:1756Same here. -
TYPO3com voted on patch set 1 V -1 03/29/17, 14:58 Completed build in 08m 24s on Wed, 29 Mar, 04:58 PM Test Summary: 3 of 56528 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9913
-
Eric Chavaillaz uploaded patch set 2 03/29/17, 15:01
-
Eric Chavaillaz uploaded patch set 3 03/29/17, 15:05
-
TYPO3com voted on patch set 2 V -1 03/29/17, 15:10 Completed build in 08m 30s on Wed, 29 Mar, 05:10 PM Test Summary: 3 of 56528 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9914
-
TYPO3com voted on patch set 3 V +1 03/29/17, 15:14 Completed build in 09m 07s on Wed, 29 Mar, 05:14 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9915
-
Eric Chavaillaz uploaded patch set 4 03/29/17, 15:23
-
TYPO3com voted on patch set 4 V -1 03/29/17, 15:33 Completed build in 09m 42s on Wed, 29 Mar, 05:33 PM Test Summary: 12 of 56552 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9916
-
Eric Chavaillaz uploaded patch set 5 03/30/17, 09:09
-
Eric Chavaillaz uploaded patch set 6 03/30/17, 09:12
-
TYPO3com voted on patch set 5 V +1 03/30/17, 09:21 Completed build in 12m 21s on Thu, 30 Mar, 11:21 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9948
-
TYPO3com voted on patch set 6 V +1 03/30/17, 09:24 Completed build in 11m 22s on Thu, 30 Mar, 11:24 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9949
-
Xavier Perseguers voted on patch set 6 CR +1 03/30/17, 14:10
-
Christian Kuhn commented on patch set 6 CR -1 03/30/17, 22:34
not in v8 anymore, will be unblocked after branching. -
Eric Chavaillaz uploaded patch set 7 03/31/17, 09:29
-
TYPO3com voted on patch set 7 V +1 03/31/17, 09:37 Completed build in 07m 17s on Fri, 31 Mar, 11:37 AM Test Summary: 56579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10034
-
Xavier Perseguers commented on patch set 7 CR -1 03/31/17, 14:02
not in v8 anymore, will be unblocked after branching -
Eric Chavaillaz uploaded patch set 8 04/10/17, 14:38
-
TYPO3com voted on patch set 8 V +1 04/10/17, 14:45 Completed build in 07m 00s on Mon, 10 Apr, 04:45 PM Test Summary: 56654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10442
-
Xavier Perseguers commented on patch set 8 CR -1 04/11/17, 08:10
Branching did not yet happen, waiting for v9. -
Eric Chavaillaz uploaded patch set 9 04/20/17, 07:19
-
TYPO3com voted on patch set 9 V -1 04/20/17, 07:19 Completed build in 06s on Thu, 20 Apr, 09:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10746
-
Xavier Perseguers commented on patch set 9 CR -1 04/20/17, 07:35
DatabaseRowDateTimeFields.php:36factor that outside of the loopDatabaseRowDateTimeFields.php:38this makes no sense to ask for this format again and again with each column, please let it factored outside of the loop.BackendUtility.php:2552Let's be consistant and change that test to use === instead of !== to be similar to Form/FormDataProvider/TcaRecordTitle.phpBackendUtility.php:2579same hereBackendUtility.php:2589same hereBackendUtility.php:2599same hereDataHandler.php:1751factor that outDataMapper.php:329factor that out -
Eric Chavaillaz uploaded patch set 10 04/20/17, 08:02
-
TYPO3com voted on patch set 10 V -1 04/20/17, 08:02 Completed build in 06s on Thu, 20 Apr, 10:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10748
-
Benni Mack commented on patch set 10 09/09/17, 23:13
hey, are you interested in pushing this change? if so, please update the patch please. -
Eric Chavaillaz commented on patch set 10 09/12/17, 05:09
Yes, I will take the time to do it this week... -
Eric Chavaillaz uploaded patch set 11 09/20/17, 12:43
-
TYPO3com voted on patch set 11 V -1 09/20/17, 12:44 Completed build in 13s on Wed, 20 Sep, 02:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15071
-
Eric Chavaillaz uploaded patch set 12 09/20/17, 13:19
-
TYPO3com voted on patch set 12 V +1 09/20/17, 13:32 Completed build in 13m 00s on Wed, 20 Sep, 03:32 PM Test Summary: 56793 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15073
-
Benni Mack commented on patch set 12 CR -1 09/20/17, 13:41
TcaRecordTitle.php:21this seems wrong (as the LanguageService has moved to core) -
Eric Chavaillaz uploaded patch set 13 09/20/17, 13:52
-
TYPO3com voted on patch set 13 V +1 09/20/17, 14:06 Completed build in 13m 39s on Wed, 20 Sep, 04:06 PM Test Summary: 56793 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15074
-
Benni Mack commented on patch set 13 CR -1 09/26/17, 05:10
Hey Eric, seems like your patch reverts the recent logging API changes (e.g. in BackendUtility). Could you incorporate the latest changes? -
Eric Chavaillaz uploaded patch set 14 09/26/17, 05:44
-
Eric Chavaillaz commented on patch set 14 09/26/17, 05:44
Thanks Benni, fixes in patch 14TcaRecordTitle.php:21ReplyYes it is true. Fixed in patch 13. Thanks -
TYPO3com voted on patch set 14 V +1 09/26/17, 05:59 Completed build in 15m 40s on Tue, 26 Sep, 07:59 AM Test Summary: 56793 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15147
-
Susi Moog uploaded patch set 15 11/27/17, 15:43
-
Susi Moog commented on patch set 16 11/27/17, 15:45
Published edit on patch set 15. -
TYPO3com voted on patch set 16 V +1 11/27/17, 16:00 Completed build in 14m 35s on Mon, 27 Nov, 05:00 PM Test Summary: 56840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16685
-
TYPO3com voted on patch set 15 V +1 11/27/17, 16:00 Completed build in 16m 51s on Mon, 27 Nov, 05:00 PM Test Summary: 56840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16684
-
Oliver Klee commented on patch set 17 11/27/17, 16:27
Published edit on patch set 16. -
TYPO3com voted on patch set 17 V +1 11/27/17, 16:39 Completed build in 12m 29s on Mon, 27 Nov, 05:39 PM Test Summary: 56844 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16696
-
Susi Moog uploaded patch set 18 11/27/17, 16:52
-
TYPO3com voted on patch set 18 V +1 11/27/17, 17:03 Completed build in 10m 28s on Mon, 27 Nov, 06:03 PM Test Summary: 56844 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16701
-
Susi Moog voted on patch set 18 CR +1 V +1 11/28/17, 22:23
-
Markus Klein commented on patch set 18 11/29/17, 00:40
DatabaseRowDateTimeFields.php:38CGL says that this stays at the same line as the if -
Markus Klein commented on patch set 19 11/29/17, 08:11
Published edit on patch set 18. -
Markus Klein commented on patch set 20 11/29/17, 08:20
Published edit on patch set 19. -
TYPO3com voted on patch set 19 V +1 11/29/17, 08:20 Completed build in 09m 04s on Wed, 29 Nov, 09:20 AM Test Summary: 56886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16891
-
Markus Klein commented on patch set 21 11/29/17, 08:20
Published edit on patch set 20. -
Markus Klein commented on patch set 22 11/29/17, 08:21
Published edit on patch set 21. -
Markus Klein voted on patch set 22 CR +1 11/29/17, 08:22
-
TYPO3com voted on patch set 22 V +1 11/29/17, 08:32 Completed build in 10m 59s on Wed, 29 Nov, 09:32 AM Test Summary: 56886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16894
-
Susi Moog voted on patch set 22 CR +1 V +1 11/29/17, 14:03
-
Markus Klein voted on patch set 22 CR +2 V +2 11/29/17, 14:54
-
Gerrit merged patch set 22 11/29/17, 14:54
DatabaseRowDateTimeFields.php:40