Review main Merged

52251[BUGFIX] Prevent extbase persistance to try last_insert_id on relations

Anja Leichsenring CR +2 V +2 Easy +3 −2 updated 03/30/17, 02:47

Commit message

Postgres will fail with an error, if a table sequence is requested for
a table without auto_increment column. MySql will just return '0'.
Test the relation type before trying to persist mm relations to
prevent that error.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Anja Leichsenring uploaded patch set 1 03/29/17, 18:41

  2. Anja Leichsenring commented on patch set 2 03/29/17, 18:53

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V +1 03/29/17, 18:53 Completed build in 11m 44s on Wed, 29 Mar, 08:53 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9922

  4. TYPO3com voted on patch set 2 V +1 03/29/17, 19:02 Completed build in 09m 08s on Wed, 29 Mar, 09:02 PM Test Summary: 56519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9924

  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 03/29/17, 19:55

  6. Georg Ringer voted on patch set 2 CR +2 V +2 03/30/17, 02:47

  7. Gerrit merged patch set 2 03/30/17, 02:47