Review main Abandoned

52255[TASK] Install Tool clear processed files using ajax

Marc Wessels CR 0 V 0 Hard +231 −40 updated 07/09/17, 11:58

Commit message

The 'Clear processed files' button used a controller action,
but it can be improved by using a simple ajax call.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1319

  1. Marc Wessels uploaded patch set 1 03/30/17, 09:24

  2. Mathias Brodala commented on patch set 1 03/30/17, 09:31

    Install.js:1060

    Any specific reason this is not an idea like the others above?
  3. Marc Wessels uploaded patch set 2 03/30/17, 09:31

  4. TYPO3com voted on patch set 1 V +1 03/30/17, 09:33 Completed build in 09m 03s on Thu, 30 Mar, 11:33 AM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9950

  5. Mathias Brodala commented on patch set 1 03/30/17, 09:38

    Install.js:1060 Reply

    This should read "ID" of course. ;-)
  6. TYPO3com voted on patch set 2 V +1 03/30/17, 09:41 Completed build in 09m 17s on Thu, 30 Mar, 11:41 AM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9951

  7. Marc Wessels uploaded patch set 3 03/30/17, 10:03

  8. TYPO3com voted on patch set 3 V +1 03/30/17, 10:11 Completed build in 08m 11s on Thu, 30 Mar, 12:11 PM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9954

  9. Marc Wessels uploaded patch set 4 03/31/17, 09:01

  10. TYPO3com voted on patch set 4 V -1 03/31/17, 09:14 Completed build in 13m 38s on Fri, 31 Mar, 11:14 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10029

  11. Marc Wessels uploaded patch set 5 03/31/17, 10:04

  12. TYPO3com voted on patch set 5 V +1 03/31/17, 10:16 Completed build in 12m 15s on Fri, 31 Mar, 12:16 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10038

  13. Frank Nägler voted on patch set 5 CR +1 V +1 03/31/17, 13:38

  14. Markus Klein updated the commit message in patch set 6 03/31/17, 13:46

  15. Frank Nägler voted on patch set 6 CR +1 V +1 03/31/17, 13:47

  16. Markus Klein commented on patch set 6 CR -1 V -1 03/31/17, 13:48

    Install.js:1177

    trailing

    Install.js:1200

    this is wrong, since you query a class an not an id. this is always true, even if nothing is found. check the length
  17. Markus Klein commented on patch set 6 03/31/17, 13:49

    Install.js:970

    this is not valid jsdoc afaik.
  18. TYPO3com voted on patch set 6 V -1 03/31/17, 13:53 Completed build in 07m 31s on Fri, 31 Mar, 03:53 PM Test Summary: 70 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10074

  19. Marc Wessels abandoned the change 07/09/17, 11:58

    Included in Change 53109