Review main Merged

52256[TASK] Install Tool reset BE User with Ajax

Marc Wessels CR +2 V +2 Hard +231 −27 updated 07/14/17, 21:48

Commit message

The 'Reset backend user preferences' button used a
controller action, but it can be improved by an ajax call.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Hamid +1
  • Verified V +2
    • Christian Kuhn +2
    • Preben Sørensen +1
    • Philipp Hamid +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1419

  1. Marc Wessels uploaded patch set 1 03/30/17, 10:05

  2. TYPO3com voted on patch set 1 V +1 03/30/17, 10:15 Completed build in 09m 11s on Thu, 30 Mar, 12:15 PM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9955

  3. Marc Wessels uploaded patch set 2 03/31/17, 08:43

  4. Frank Nägler commented on patch set 1 03/31/17, 08:50

    AjaxController.php:37

    I think this should not be removed
  5. TYPO3com voted on patch set 2 V -1 03/31/17, 08:56 Completed build in 12m 28s on Fri, 31 Mar, 10:56 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10024

  6. Marc Wessels uploaded patch set 3 03/31/17, 09:20

  7. TYPO3com voted on patch set 3 V -1 03/31/17, 09:33 Completed build in 12m 33s on Fri, 31 Mar, 11:33 AM Test Summary: 1 of 56564 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10033

  8. Frank Nägler commented on patch set 3 CR -1 03/31/17, 09:34

    on it

    AjaxController.php:37 Reply

    sry, ignore my comment -.-
  9. Marc Wessels uploaded patch set 4 03/31/17, 10:02

  10. TYPO3com voted on patch set 4 V +1 03/31/17, 10:12 Completed build in 09m 47s on Fri, 31 Mar, 12:12 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10037

  11. Frank Nägler voted on patch set 4 CR +1 V +1 03/31/17, 13:41

  12. Christian Kuhn commented on patch set 4 CR -1 03/31/17, 20:25

    decided -1 on this for v8, we can do that in v9.
  13. Christian Kuhn voted on patch set 4 CR 0 05/11/17, 15:05

  14. Jan Helke uploaded patch set 5 05/11/17, 15:15

  15. TYPO3com voted on patch set 5 V +1 05/11/17, 15:22 Completed build in 06m 25s on Thu, 11 May, 05:22 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11426

  16. Preben Sørensen voted on patch set 5 V +1 07/14/17, 21:32

  17. Philipp Hamid voted on patch set 5 CR +1 V +1 07/14/17, 21:48

  18. Christian Kuhn voted on patch set 5 CR +2 V +2 07/14/17, 21:48

  19. Gerrit merged patch set 5 07/14/17, 21:48